Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oct-HSM support #11027

Closed
3 tasks done
heaths opened this issue Sep 4, 2020 · 3 comments · Fixed by #11370
Closed
3 tasks done

Add oct-HSM support #11027

heaths opened this issue Sep 4, 2020 · 3 comments · Fixed by #11370
Assignees
@sadasant
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2020] October

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020 •
edited by sadasant
Loading

For Key Vault 7.2-preview, make sure "oct" is already supported, and add "oct-HSM" support to models (names taken from swagger):

  • KeyProperties.kty
  • KeyCreateParameters.kty
  • JsonWebKey.kty

See the service version 7.1 -> 7.2-preview diff 🔒 for details.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Sep 11, 2020
@sadasant
Copy link
Contributor

The create key parameters seem to be missing several properties. Here's another example: #11263

I'll probably address these in the same PR. Something like "align create key options bag".

@sadasant
Copy link
Contributor

Disregard, the createKey method receives the keyType directly. That leaves #11263 out of the picture.

@sadasant sadasant mentioned this issue Sep 21, 2020
Merged
@sadasant
Copy link
Contributor

I believe that #11370 is enough to close this issue.

@sadasant sadasant mentioned this issue Sep 24, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Dec 9, 2020
CodeGen from PR 11027 in Azure/azure-rest-api-specs
d79700d 
Eventhub: Added APIs to 2018-01-01-preview API version (Azure#11027)

* Added support for all API in 2018-preview version

* removed extra files

* fixed UNREFERENCED_JSON_FILE

* update

* prettier fix

Co-authored-by: v-ajnava <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

[Key Vault] Use the swagger generated from the service 7.2-preview sadasant/azure-sdk-for-js
3 participants
@sadasant @heaths @ramya-rao-a