Skip to content

Commit

Permalink
Remove Node.js 10 from test matrix (#18403)
Browse files Browse the repository at this point in the history
* Remove Node.js 10 from test matrix

* Fix text that has node version
  • Loading branch information
ramya-rao-a authored Oct 29, 2021
1 parent ec1462c commit cc8130b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions eng/pipelines/templates/jobs/smoke.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ jobs:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
ArmTemplateParameters: $(AzureCloudArmTemplateParameters)
NodeTestVersion: "16.x"
# Linux Node10 (AzureUSGovernment):
# Linux Node12 (AzureUSGovernment):
# Pool: Azure Pipelines
# OSVmImage: "ubuntu-18.04"
# SubscriptionConfiguration: $(sub-config-gov-test-resources)
# ArmTemplateParameters: $(AzureUSGovernmentArmTemplateParameters)
# NodeTestVersion: "10.x"
# NodeTestVersion: "12.x"
# Windows Node14 (AzureUSGovernment):
# Pool: Azure Pipelines
# OSVmImage: "windows-2019"
Expand All @@ -97,12 +97,12 @@ jobs:
# SubscriptionConfiguration: $(sub-config-cn-test-resources)
# ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters)
# NodeTestVersion: "12.x"
# Windows Node10 (AzureChinaCloud):
# Windows Node12 (AzureChinaCloud):
# Pool: Azure Pipelines
# OSVmImage: "windows-2019"
# SubscriptionConfiguration: $(sub-config-cn-test-resources)
# ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters)
# NodeTestVersion: "10.x"
# NodeTestVersion: "12.x"

pool:
name: $(Pool)
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/stages/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"Pool": "Azure Pipelines"
}
},
"NodeTestVersion": ["10.x", "12.x", "14.x", "16.x"],
"NodeTestVersion": ["12.x", "14.x", "16.x"],
"TestType": "node",
"TestResultsFiles": "**/test-results.xml"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
},
"TestType": "node",
"NodeTestVersion": "10.x"
"NodeTestVersion": "12.x"
}
]
}
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
},
"TestType": "node",
"NodeTestVersion": "10.x"
"NodeTestVersion": "12.x"
},
{
"Agent": {
Expand Down

0 comments on commit cc8130b

Please sign in to comment.