Skip to content

Commit

Permalink
[app-configuration] Reference the correct .d.ts file in package.json (#…
Browse files Browse the repository at this point in the history
…5218)

* Fixing issue where the typings file was not properly referenced.
* Updating changelog to note fix as well as changes since last preview.
  • Loading branch information
richardpark-msft authored Sep 24, 2019
1 parent 6b3c8d8 commit c85a4c3
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
29 changes: 29 additions & 0 deletions sdk/appconfiguration/app-configuration/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,32 @@
# 1.0.0-preview.4 (TBD)

### Breaking changes from 1.0.0-preview.3:

This release brings our interface a bit closer to what is offered in the
Azure SDKs for C# and Java for AppConfig.

This affects the `setConfigurationSetting` and `getConfigurationSetting`
methods which no longer take a `key` parameter and instead take
a `ConfigurationSetting`.

In previous previews:
```typescript
// 1.0.0-preview.3 and below
await client.addConfigurationSetting("MyKey", { label: "MyLabel", value: "MyValue" });
await client.setConfigurationSetting("MyKey", { label: "MyLabel", value: "MyValue" });
```

Now in preview.4:
```typescript
// 1.0.0-preview.4
await client.addConfigurationSetting({ key: "MyKey", label: "MyLabel", value: "MyValue" });
await client.setConfigurationSetting({ key: "MyKey", label: "MyLabel", value: "MyValue" });
```

# 1.0.0-preview.3 (2019-09-23)

- Typings file was incorrectly packaged (#5217)

# 1.0.0-preview.2 (2019-09-13)

Republishing as the readme is not properly showing up on npmjs. No other changes.
Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/app-configuration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@azure/app-configuration",
"author": "Microsoft Corporation",
"description": "An isomorphic client library for the Azure App Configuration service.",
"version": "1.0.0-preview.2",
"version": "1.0.0-preview.4",
"sdk-type": "client",
"dependencies": {
"@azure/core-arm": "1.0.0-preview.3",
Expand All @@ -20,7 +20,7 @@
"license": "MIT",
"main": "./dist/index.js",
"module": "./dist-esm/src/index.js",
"types": "./types/src/index.d.ts",
"types": "./types/app-configuration.d.ts",
"devDependencies": {
"@microsoft/api-extractor": "^7.1.5",
"@types/dotenv": "^6.1.0",
Expand Down

0 comments on commit c85a4c3

Please sign in to comment.