Skip to content

Commit

Permalink
[Storage] Blob tags - resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
XiaoningLiu committed Jun 12, 2020
1 parent e4765c7 commit c798641
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
5 changes: 1 addition & 4 deletions sdk/storage/storage-blob/review/storage-blob.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2694,10 +2694,7 @@ export class StorageSharedKeyCredentialPolicy extends CredentialPolicy {
export type SyncCopyStatusType = 'success';

// @public
export interface Tags {
// (undocumented)
[propertyName: string]: string;
}
export type Tags = Record<string, string>;

// @public
export interface UserDelegationKey {
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/src/BlobSASPermissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class BlobSASPermissions {
public delete: boolean = false;

/**
* Specfies Tag access granted.
* Specifies Tag access granted.
*
* @type {boolean}
* @memberof BlobSASPermissions
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/storage-blob/src/BlobServiceClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,8 @@ export class BlobServiceClient extends StorageClient {
*
* .byPage() returns an async iterable iterator to list the blobs in pages.
*
* @see https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob-service-properties
*
* Example using `for await` syntax:
*
* ```js
Expand Down
7 changes: 1 addition & 6 deletions sdk/storage/storage-blob/src/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,8 @@ import { EncryptionAlgorithmAES25 } from "./utils/constants";

/**
* Blob tags.
*
* @export
* @interface Tags
*/
export interface Tags {
[propertyName: string]: string;
}
export type Tags = Record<string, string>;

/**
* A map of name-value pairs to associate with the resource.
Expand Down

0 comments on commit c798641

Please sign in to comment.