[Language Text] Mitigating bug in auto detected language for TA4H

Azure · Nov 4, 2022 · 9d39baf · 9d39baf
1 parent a8a5e9e
commit 9d39baf
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 29 deletions.
diff --git a/sdk/cognitivelanguage/ai-language-text/src/generated/models/index.ts b/sdk/cognitivelanguage/ai-language-text/src/generated/models/index.ts
diff --git a/sdk/cognitivelanguage/ai-language-text/src/generated/models/mappers.ts b/sdk/cognitivelanguage/ai-language-text/src/generated/models/mappers.ts
diff --git a/sdk/cognitivelanguage/ai-language-text/src/transforms.ts b/sdk/cognitivelanguage/ai-language-text/src/transforms.ts
@@ -50,6 +50,8 @@ import {
   CustomEntitiesResultDocumentsItem,
   ExtractedSummaryDocumentResultWithDetectedLanguage,
   AbstractiveSummaryDocumentResultWithDetectedLanguage,
+  HealthcareResultDocumentsItem,
+  DetectedLanguage,
 } from "./generated";
 import {
   AnalyzeActionName,
@@ -74,6 +76,7 @@ import {
   TextAnalysisError,
   TextAnalysisErrorResult,
   TextAnalysisSuccessResult,
+  WithDetectedLanguage,
 } from "./models";
 import {
   AssessmentIndex,
@@ -392,20 +395,34 @@ function toHealthcareResult(
       ),
     });
   }
-  return transformDocumentResults<HealthcareEntitiesDocumentResult, HealthcareSuccessResult>(
-    docIds,
-    results,
-    {
-      processSuccess: ({ entities, relations, ...rest }) => {
-        const newEntities = entities.map(makeHealthcareEntity);
-        return {
-          entities: newEntities,
-          entityRelations: relations.map(makeHealthcareRelation(newEntities)),
-          ...rest,
-        };
-      },
+  function deserializeDetectedLanguage(input: string): DetectedLanguage {
+    function helper(str: string): undefined {
+      try {
+        return JSON.parse(str);
+      } catch (e) {
+        return undefined;
+      }
     }
-  );
+    const obj = helper(input);
+    return obj !== undefined ? obj : ({ iso6391Name: input } as any);
+  }
+  return transformDocumentResults<
+    HealthcareResultDocumentsItem,
+    WithDetectedLanguage<HealthcareSuccessResult>
+  >(docIds, results, {
+    processSuccess: ({ entities, relations, detectedLanguage, ...rest }) => {
+      const newEntities = entities.map(makeHealthcareEntity);
+      return {
+        entities: newEntities,
+        entityRelations: relations.map(makeHealthcareRelation(newEntities)),
+        // FIXME: remove this mitigation when the API fixes the representation on their end
+        ...(detectedLanguage
+          ? { detectedLanguage: deserializeDetectedLanguage(detectedLanguage) }
+          : {}),
+        ...rest,
+      };
+    },
+  });
 }
 
 function toCustomSingleLabelClassificationResult(

diff --git a/sdk/cognitivelanguage/ai-language-text/swagger/README.md b/sdk/cognitivelanguage/ai-language-text/swagger/README.md
@@ -12,7 +12,8 @@ generate-metadata: false
 license-header: MICROSOFT_MIT_NO_VERSION
 output-folder: ../
 source-code-folder-path: ./src/generated
-input-file: https://github.com/Azure/azure-rest-api-specs/blob/ac205086f477776e8d9aa4ff771e98f174afbea2/specification/cognitiveservices/data-plane/Language/preview/2022-10-01-preview/analyzetext.json
+input-file: ./swagger.json
+#input-file: https://github.com/Azure/azure-rest-api-specs/blob/ac205086f477776e8d9aa4ff771e98f174afbea2/specification/cognitiveservices/data-plane/Language/preview/2022-10-01-preview/analyzetext.json
 add-credentials: false
 package-version: 1.1.0-beta.1
 v3: true