Skip to content

Commit

Permalink
[Core asynciterator] Update linting scripts and apply auto linting an…
Browse files Browse the repository at this point in the history
…d some formatting (#11272)

* update linting scripts

* edits

* turn off relevant rules and lint package.json back

* adding .eslintrc.json
  • Loading branch information
deyaaeldeen authored Sep 23, 2020
1 parent 5fa7f3f commit 901b9f7
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 15 deletions.
19 changes: 19 additions & 0 deletions sdk/core/core-asynciterator-polyfill/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"plugins": ["@azure/azure-sdk"],
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
"rules": {
// `package.json`'s sideEffects has to be true because this package loads a
// polyfill.
"@azure/azure-sdk/ts-package-json-sideeffects": "off",
// this package does not have a module in `dist` because the directory does
// not exist.
"@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
// this package does not export a module.
"@azure/azure-sdk/ts-package-json-module": "off",
// this package does not create a `dist` directory to be included in `files`
// list in `package.json`.
"@azure/azure-sdk/ts-package-json-files-required": "off",
// this package does not have type declaration file.
"@azure/azure-sdk/ts-package-json-types": "off"
}
}
29 changes: 14 additions & 15 deletions sdk/core/core-asynciterator-polyfill/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{
"name": "@azure/core-asynciterator-polyfill",
"author": {
"name": "Microsoft Corporation",
"email": "[email protected]",
"url": "https://github.com/Azure/azure-sdk-for-js"
},
"author": "Microsoft Corporation",
"sdk-type": "client",
"version": "1.0.1",
"description": "Polyfill for IE/Node 8 for Symbol.asyncIterator",
Expand All @@ -14,22 +10,24 @@
],
"keywords": [
"microsoft",
"clientruntime"
"clientruntime",
"azure",
"cloud"
],
"main": "./dist-esm/index.js",
"files": [
"dist-esm/**/*.js",
"dist-esm/index.js",
"README.md",
"LICENSE"
],
"license": "MIT",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-asynciterator-polyfill",
"repository": {
"type": "git",
"url": "[email protected]:Azure/azure-sdk-for-js.git"
"engines": {
"node": ">=8.0.0"
},
"license": "MIT",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-asynciterator-polyfill/README.md",
"repository": "github:Azure/azure-sdk-for-js",
"bugs": {
"url": "http://github.com/Azure/azure-sdk-for-js/issues"
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
},
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
Expand All @@ -42,8 +40,8 @@
"integration-test:browser": "echo skipped",
"integration-test:node": "echo skipped",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint": "eslint -c ../../.eslintrc.old.json src --ext .ts -f html -o template-lintReport.html || exit 0",
"lint:fix": "eslint \"src/**/*.ts\" -c ../../.eslintrc.old.json --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json src --ext .ts",
"lint:fix": "eslint package.json src --ext .ts --fix --fix-type [problem,suggestion]",
"pack": "npm pack 2>&1",
"prebuild": "npm run clean",
"test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
Expand All @@ -56,6 +54,7 @@
"sideEffects": true,
"private": false,
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@types/node": "^8.0.0",
"@typescript-eslint/eslint-plugin": "^2.0.0",
"@typescript-eslint/parser": "^2.0.0",
Expand Down
3 changes: 3 additions & 0 deletions sdk/core/core-asynciterator-polyfill/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

if (typeof Symbol === undefined || !(Symbol as any).asyncIterator) {
(Symbol as any).asyncIterator = Symbol.for("Symbol.asyncIterator");
}

0 comments on commit 901b9f7

Please sign in to comment.