Fix circular dependencies in @azure/cosmos (#5374)

* Fix circular dependencies in @azure/cosmos * convert RequestCharge header to number
Azure · Oct 8, 2019 · 880dc80 · 880dc80
1 parent 560b14f
commit 880dc80
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/sdk/cosmosdb/cosmos/src/queryExecutionContext/defaultQueryExecutionContext.ts b/sdk/cosmosdb/cosmos/src/queryExecutionContext/defaultQueryExecutionContext.ts
@@ -185,6 +185,7 @@ export class DefaultQueryExecutionContext implements ExecutionContext {
 
       // Add the request charge to the query metrics so that we can have per partition request charge.
       if (Constants.HttpHeaders.RequestCharge in responseHeaders) {
+        const requestCharge = Number(responseHeaders[Constants.HttpHeaders.RequestCharge]) || 0;
         queryMetrics = new QueryMetrics(
           queryMetrics.retrievedDocumentCount,
           queryMetrics.retrievedDocumentSize,
@@ -198,7 +199,7 @@ export class DefaultQueryExecutionContext implements ExecutionContext {
           queryMetrics.vmExecutionTime,
           queryMetrics.runtimeExecutionTimes,
           queryMetrics.documentWriteTime,
-          new ClientSideMetrics(responseHeaders[Constants.HttpHeaders.RequestCharge])
+          new ClientSideMetrics(requestCharge)
         );
       }
 

diff --git a/sdk/cosmosdb/cosmos/src/queryMetrics/clientSideMetrics.ts b/sdk/cosmosdb/cosmos/src/queryMetrics/clientSideMetrics.ts
@@ -1,6 +1,5 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-import { getRequestChargeIfAny } from "../queryExecutionContext/headerUtils";
 
 export class ClientSideMetrics {
   constructor(public readonly requestCharge: number) {}
@@ -15,7 +14,7 @@ export class ClientSideMetrics {
         throw new Error("clientSideMetrics has null or undefined item(s)");
       }
 
-      requestCharge += getRequestChargeIfAny(clientSideMetrics.requestCharge);
+      requestCharge += clientSideMetrics.requestCharge;
     }
 
     return new ClientSideMetrics(requestCharge);

diff --git a/sdk/cosmosdb/cosmos/src/request/RequestHandler.ts b/sdk/cosmosdb/cosmos/src/request/RequestHandler.ts
@@ -17,8 +17,7 @@ import { TimeoutError } from "./TimeoutError";
 /** @hidden */
 const log = logger("RequestHandler");
 
-/** @hidden */
-export async function executeRequest(requestContext: RequestContext) {
+async function executeRequest(requestContext: RequestContext) {
   return executePlugins(requestContext, httpRequest, PluginOn.request);
 }
 
@@ -143,6 +142,7 @@ export async function request<T>(requestContext: RequestContext): Promise<Cosmos
   }
 
   return RetryUtility.execute({
-    requestContext
+    requestContext,
+    executeRequest
   });
 }
diff --git a/sdk/cosmosdb/cosmos/src/retry/retryUtility.ts b/sdk/cosmosdb/cosmos/src/retry/retryUtility.ts
@@ -6,7 +6,6 @@ import { StatusCodes, SubStatusCodes } from "../common/statusCodes";
 import { Response } from "../request";
 import { LocationRouting } from "../request/LocationRouting";
 import { RequestContext } from "../request/RequestContext";
-import { executeRequest } from "../request/RequestHandler";
 import { DefaultRetryPolicy } from "./defaultRetryPolicy";
 import { EndpointDiscoveryRetryPolicy } from "./endpointDiscoveryRetryPolicy";
 import { ResourceThrottleRetryPolicy } from "./resourceThrottleRetryPolicy";
@@ -21,6 +20,7 @@ interface ExecuteArgs {
   retryContext?: RetryContext;
   retryPolicies?: RetryPolicies;
   requestContext: RequestContext;
+  executeRequest: (requestContext: RequestContext) => Promise<Response<any>>;
 }
 
 /**
@@ -41,7 +41,8 @@ interface RetryPolicies {
 export async function execute({
   retryContext = {},
   retryPolicies,
-  requestContext
+  requestContext,
+  executeRequest
 }: ExecuteArgs): Promise<Response<any>> {
   // TODO: any response
   if (!retryPolicies) {
@@ -121,6 +122,7 @@ export async function execute({
       }
       await sleep(retryPolicy.retryAfterInMilliseconds);
       return execute({
+        executeRequest,
         requestContext,
         retryContext,
         retryPolicies