[Cosmos] Return to node-abort-controller (#5555)

* Bring back node-abort-controller * 3.3.5 * pnpm update
Azure · Oct 14, 2019 · 76ad872 · 76ad872
1 parent 71302ce
commit 76ad872
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 48 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/cosmosdb/cosmos/package.json b/sdk/cosmosdb/cosmos/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@azure/cosmos",
-  "version": "3.3.4",
+  "version": "3.3.5",
   "description": "Microsoft Azure Cosmos DB Service Node.js SDK for SQL API",
   "sdk-type": "client",
   "keywords": [
@@ -73,7 +73,6 @@
     "tsdocFlavor": "AEDoc"
   },
   "dependencies": {
-    "@azure/abort-controller": "1.0.0-preview.2",
     "@types/debug": "^4.1.4",
     "debug": "^4.1.1",
     "fast-json-stable-stringify": "^2.0.0",
@@ -121,6 +120,7 @@
     "mocha": "^6.2.0",
     "mocha-junit-reporter": "^1.18.0",
     "mocha-multi": "^1.1.3",
+    "node-abort-controller": "1.0.4",
     "prettier": "^1.16.4",
     "proxy-agent": "3.0.3",
     "requirejs": "^2.3.5",

diff --git a/sdk/cosmosdb/cosmos/review/cosmos.api.md b/sdk/cosmosdb/cosmos/review/cosmos.api.md
@@ -578,12 +578,12 @@ export class Items {
     query<T>(query: string | SqlQuerySpec, options: FeedOptions): QueryIterator<T>;
     readAll(options?: FeedOptions): QueryIterator<ItemDefinition>;
     readAll<T extends ItemDefinition>(options?: FeedOptions): QueryIterator<T>;
-    readChangeFeed<T>(changeFeedOptions?: ChangeFeedOptions): ChangeFeedIterator<T>;
     // Warning: (ae-forgotten-export) The symbol "ChangeFeedOptions" needs to be exported by the entry point index.d.ts
     // Warning: (ae-forgotten-export) The symbol "ChangeFeedIterator" needs to be exported by the entry point index.d.ts
     readChangeFeed(partitionKey: string | number | boolean, changeFeedOptions: ChangeFeedOptions): ChangeFeedIterator<any>;
     readChangeFeed(changeFeedOptions?: ChangeFeedOptions): ChangeFeedIterator<any>;
     readChangeFeed<T>(partitionKey: string | number | boolean, changeFeedOptions: ChangeFeedOptions): ChangeFeedIterator<T>;
+    readChangeFeed<T>(changeFeedOptions?: ChangeFeedOptions): ChangeFeedIterator<T>;
     upsert(body: any, options?: RequestOptions): Promise<ItemResponse<ItemDefinition>>;
     upsert<T extends ItemDefinition>(body: T, options?: RequestOptions): Promise<ItemResponse<T>>;
 }

diff --git a/sdk/cosmosdb/cosmos/rollup.config.js b/sdk/cosmosdb/cosmos/rollup.config.js
@@ -7,7 +7,7 @@ export default [
       "universal-user-agent",
       "uuid/v4",
       "debug",
-      "@azure/abort-controller",
+      "node-abort-controller",
       "node-fetch",
       "priorityqueuejs",
       "semaphore",
@@ -23,7 +23,7 @@ export default [
         "universal-user-agent": "universalUserAgent",
         "fast-json-stable-stringify": "stableStringify",
         "uuid/v4": "uuid",
-        "@azure/abort-controller": "AbortController",
+        "node-abort-controller": "AbortController",
         "node-fetch": "fetch",
         crypto: "crypto",
         tslib: "tslib_1",

diff --git a/sdk/cosmosdb/cosmos/src/request/RequestHandler.ts b/sdk/cosmosdb/cosmos/src/request/RequestHandler.ts
@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-import { AbortController } from "@azure/abort-controller";
+import AbortController from "node-abort-controller";
 import fetch, { RequestInit, Response } from "node-fetch";
 import { trimSlashes } from "../common";
 import { Constants } from "../common/constants";

diff --git a/sdk/cosmosdb/cosmos/test/functional/client.spec.ts b/sdk/cosmosdb/cosmos/test/functional/client.spec.ts
@@ -10,7 +10,7 @@ import {
   generateDocuments,
   bulkInsertItems
 } from "../common/TestHelpers";
-import { AbortController } from "@azure/abort-controller";
+import AbortController from "node-abort-controller";
 
 describe("NodeJS CRUD Tests", function() {
   this.timeout(process.env.MOCHA_TIMEOUT || 20000);