Upgrade TypeScript to 4.8 for most packages (#23730)

Azure · Nov 5, 2022 · 526926a · 526926a
1 parent ceb5483
commit 526926a
Show file tree

Hide file tree

Showing 130 changed files with 319 additions and 306 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/agrifood/agrifood-farming-rest/package.json b/sdk/agrifood/agrifood-farming-rest/package.json
@@ -125,6 +125,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/agrifood/agrifood-farming-rest/samples/v1/typescript/package.json b/sdk/agrifood/agrifood-farming-rest/samples/v1/typescript/package.json
@@ -35,7 +35,7 @@
     "@azure/identity": "^2.0.1"
   },
   "devDependencies": {
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/anomalydetector/ai-anomaly-detector/package.json b/sdk/anomalydetector/ai-anomaly-detector/package.json
@@ -97,7 +97,7 @@
     "nyc": "^15.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1",
     "@azure-tools/test-recorder": "^1.0.0"
   },

diff --git a/sdk/anomalydetector/ai-anomaly-detector/samples/v3/typescript/package.json b/sdk/anomalydetector/ai-anomaly-detector/samples/v3/typescript/package.json
@@ -33,7 +33,7 @@
     "csv-parse": "^4.4.0"
   },
   "devDependencies": {
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/appconfiguration/app-configuration/package.json b/sdk/appconfiguration/app-configuration/package.json
@@ -128,7 +128,7 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "uglify-js": "^3.4.9",
     "uuid": "^8.3.0",
     "cross-env": "^7.0.2"

diff --git a/sdk/appconfiguration/app-configuration/samples/v1-beta/typescript/package.json b/sdk/appconfiguration/app-configuration/samples/v1-beta/typescript/package.json
@@ -38,7 +38,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/appconfiguration/app-configuration/samples/v1/typescript/package.json b/sdk/appconfiguration/app-configuration/samples/v1/typescript/package.json
@@ -36,7 +36,7 @@
     "@azure/identity": "^2.0.1"
   },
   "devDependencies": {
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/attestation/attestation/package.json b/sdk/attestation/attestation/package.json
@@ -141,7 +141,7 @@
     "safe-buffer": "^5.2.1",
     "source-map-support": "^0.5.9",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   },
   "//sampleConfiguration": {

diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json
@@ -112,7 +112,7 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   },
   "//metadata": {

diff --git a/sdk/communication/communication-chat/samples/v1/typescript/package.json b/sdk/communication/communication-chat/samples/v1/typescript/package.json
@@ -35,7 +35,7 @@
     "@azure/communication-identity": "^1.0.0"
   },
   "devDependencies": {
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/communication/communication-common/package.json b/sdk/communication/communication-common/package.json
@@ -102,7 +102,7 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   }
 }
diff --git a/sdk/communication/communication-common/src/identifierModelSerializer.ts b/sdk/communication/communication-common/src/identifierModelSerializer.ts
@@ -95,7 +95,7 @@ const assertNotNullOrUndefined = <
   if (prop in subObj) {
     return subObj[prop];
   }
-  throw new Error(`Property ${prop} is required for identifier of type ${subObjName}.`);
+  throw new Error(`Property ${String(prop)} is required for identifier of type ${subObjName}.`);
 };
 
 const assertMaximumOneNestedModel = (identifier: SerializedCommunicationIdentifier): void => {

diff --git a/sdk/communication/communication-common/test/identifierModelSerializer.spec.ts b/sdk/communication/communication-common/test/identifierModelSerializer.spec.ts
@@ -34,7 +34,7 @@ const assertThrowsMissingProperty = <
 ): void => {
   assert.throws(() => {
     deserializeCommunicationIdentifier(serializedIdentifier);
-  }, `Property ${missingPropertyName} is required for identifier of type ${identifierType}.`);
+  }, `Property ${String(missingPropertyName)} is required for identifier of type ${identifierType}.`);
 };
 
 const assertThrowsTooManyProperties = (

diff --git a/sdk/communication/communication-email/package.json b/sdk/communication/communication-email/package.json
@@ -84,7 +84,7 @@
     "mocha": "^7.1.1",
     "mocha-junit-reporter": "^2.0.0",
     "nyc": "^15.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0"
   },

diff --git a/sdk/communication/communication-email/samples/v1-beta/typescript/package.json b/sdk/communication/communication-email/samples/v1-beta/typescript/package.json
@@ -33,7 +33,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/communication/communication-identity/package.json b/sdk/communication/communication-identity/package.json
@@ -136,6 +136,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/communication/communication-identity/samples/v1/typescript/package.json b/sdk/communication/communication-identity/samples/v1/typescript/package.json
@@ -33,7 +33,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/communication/communication-sms/package.json b/sdk/communication/communication-sms/package.json
@@ -110,7 +110,7 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "@types/uuid": "^8.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   },
   "//metadata": {

diff --git a/sdk/communication/communication-sms/samples/v1/typescript/package.json b/sdk/communication/communication-sms/samples/v1/typescript/package.json
@@ -36,7 +36,7 @@
     "@azure/identity": "^2.0.1"
   },
   "devDependencies": {
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/confidentialledger/confidential-ledger-rest/package.json b/sdk/confidentialledger/confidential-ledger-rest/package.json
@@ -126,6 +126,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/confidentialledger/confidential-ledger-rest/samples/v1-beta/typescript/package.json b/sdk/confidentialledger/confidential-ledger-rest/samples/v1-beta/typescript/package.json
@@ -36,7 +36,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/containerregistry/container-registry/package.json b/sdk/containerregistry/container-registry/package.json
@@ -115,7 +115,7 @@
     "nyc": "^15.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   },
   "//sampleConfiguration": {

diff --git a/sdk/containerregistry/container-registry/samples/v1/typescript/package.json b/sdk/containerregistry/container-registry/samples/v1/typescript/package.json
@@ -33,7 +33,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/containerregistry/container-registry/src/blob/containerRegistryBlobClient.ts b/sdk/containerregistry/container-registry/src/blob/containerRegistryBlobClient.ts
@@ -45,7 +45,7 @@ function assertHasProperty<T, U extends keyof T>(
   property: U
 ): asserts obj is T & Required<Pick<T, U>> {
   if (!Object.prototype.hasOwnProperty.call(obj, property)) {
-    throw new RestError(`Expected property ${property} to be defined.`);
+    throw new RestError(`Expected property ${String(property)} to be defined.`);
   }
 }
 

diff --git a/sdk/core/abort-controller/package.json b/sdk/core/abort-controller/package.json
@@ -99,6 +99,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/core/core-amqp/package.json b/sdk/core/core-amqp/package.json
@@ -121,7 +121,7 @@
     "rollup-plugin-terser": "^5.1.1",
     "sinon": "^9.0.2",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "ws": "^8.2.0"
   }
 }
diff --git a/sdk/core/core-amqp/review/core-amqp.api.md b/sdk/core/core-amqp/review/core-amqp.api.md
@@ -196,8 +196,8 @@ export interface ConnectionConfig {
 
 // @public
 export const ConnectionConfig: {
-    create(connectionString: string, path?: string | undefined): ConnectionConfig;
-    validate(config: ConnectionConfig, options?: ConnectionConfigOptions | undefined): void;
+    create(connectionString: string, path?: string): ConnectionConfig;
+    validate(config: ConnectionConfig, options?: ConnectionConfigOptions): void;
 };
 
 // @public

diff --git a/sdk/core/core-amqp/src/auth/tokenProvider.ts b/sdk/core/core-amqp/src/auth/tokenProvider.ts
@@ -8,7 +8,6 @@ import {
   isNamedKeyCredential,
   isSASCredential,
 } from "@azure/core-auth";
-import { isObjectWithProperties } from "@azure/core-util";
 import jssha from "jssha";
 
 /**
@@ -44,7 +43,7 @@ export function createSasTokenProvider(
 ): SasTokenProvider {
   if (isNamedKeyCredential(data) || isSASCredential(data)) {
     return new SasTokenProviderImpl(data);
-  } else if (isObjectWithProperties(data, ["sharedAccessKeyName", "sharedAccessKey"])) {
+  } else if ("sharedAccessKeyName" in data && "sharedAccessKey" in data) {
     return new SasTokenProviderImpl({ name: data.sharedAccessKeyName, key: data.sharedAccessKey });
   } else {
     return new SasTokenProviderImpl({ signature: data.sharedAccessSignature });

diff --git a/sdk/core/core-auth/package.json b/sdk/core/core-auth/package.json
@@ -82,7 +82,7 @@
     "mocha-junit-reporter": "^2.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   }
 }
diff --git a/sdk/core/core-client-rest/package.json b/sdk/core/core-client-rest/package.json
@@ -89,6 +89,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/core/core-client/package.json b/sdk/core/core-client/package.json
@@ -107,7 +107,7 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   }
 }
diff --git a/sdk/core/core-http-compat/package.json b/sdk/core/core-http-compat/package.json
@@ -70,6 +70,6 @@
     "downlevel-dts": "^0.10.0",
     "cross-env": "^7.0.2",
     "prettier": "^2.5.1",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/core/core-http/package.json b/sdk/core/core-http/package.json
@@ -172,7 +172,7 @@
     "shx": "^0.3.2",
     "sinon": "^9.0.2",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "uglify-js": "^3.4.9",
     "xhr-mock": "^2.4.1"
   }

diff --git a/sdk/core/core-http/src/nodeFetchHttpClient.ts b/sdk/core/core-http/src/nodeFetchHttpClient.ts
@@ -206,7 +206,10 @@ export class NodeFetchHttpClient implements HttpClient {
       body: body,
       headers: httpRequest.headers.rawHeaders(),
       method: httpRequest.method,
-      signal: abortController.signal,
+      // the types for RequestInit are from the browser, which expects AbortSignal to
+      // have `reason` and `throwIfAborted`, but these don't exist on our polyfill
+      // for Node.
+      signal: abortController.signal as any,
       redirect: "manual",
       ...platformSpecificRequestInit,
     };

diff --git a/sdk/core/core-lro/package.json b/sdk/core/core-lro/package.json
@@ -122,6 +122,6 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/core/core-paging/package.json b/sdk/core/core-paging/package.json
@@ -95,7 +95,7 @@
     "mocha-junit-reporter": "^2.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "~4.6.0"
+    "typescript": "~4.8.0"
   },
   "//sampleConfiguration": {
     "skipFolder": true,

diff --git a/sdk/core/core-paging/samples/v1/typescript/package.json b/sdk/core/core-paging/samples/v1/typescript/package.json
@@ -33,7 +33,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/core/core-rest-pipeline/package.json b/sdk/core/core-rest-pipeline/package.json
@@ -131,7 +131,7 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   },
   "//sampleConfiguration": {

diff --git a/sdk/core/core-rest-pipeline/samples/v1/typescript/package.json b/sdk/core/core-rest-pipeline/samples/v1/typescript/package.json
@@ -30,7 +30,7 @@
     "dotenv": "latest"
   },
   "devDependencies": {
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/core/core-tracing/package.json b/sdk/core/core-tracing/package.json
@@ -86,7 +86,7 @@
     "mocha-junit-reporter": "^2.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1",
     "sinon": "^9.0.2",
     "@types/sinon": "^9.0.4"

diff --git a/sdk/core/core-tracing/samples/v1/typescript/package.json b/sdk/core/core-tracing/samples/v1/typescript/package.json
@@ -32,7 +32,7 @@
   },
   "devDependencies": {
     "@types/node": "^14.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.8.0",
     "rimraf": "latest"
   }
 }
diff --git a/sdk/core/core-util/package.json b/sdk/core/core-util/package.json
@@ -101,7 +101,7 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   }
 }
diff --git a/sdk/core/core-xml/package.json b/sdk/core/core-xml/package.json
@@ -102,7 +102,7 @@
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
-    "typescript": "~4.6.0",
+    "typescript": "~4.8.0",
     "util": "^0.12.1"
   }
 }