[KeyVault] - Enable node unit tests for KeyVault Administrator (#13230)

## What - Enable Node unit tests for KV administration package - Align our KV test-resources ARM template with dotnet's - Add Managed HSM to ARM template - Add script to enable Managed HSM from dotnet's script ## Why We have lots of changes we want to make, but tests weren't currently runnable. Making the entire suite runnable seemed like something we'd want to do early before making behavior changes. Unfortunately there are some service integration issues we want to address before we can enable _all_ the tests so we decided to pend the ones that need some extra TLC to get the suite running. Aligning with dotnet on the ARM template allows us to easily add the Managed HSM bits from them and helps standardize what our template looks like across repos. Finally, Managed HSM support is coming, so we might as well get the deployment correct now.
Azure · Jan 19, 2021 · 0cb47ee · 0cb47ee
1 parent 81d37fa
commit 0cb47ee
Show file tree

Hide file tree

Showing 38 changed files with 934 additions and 206 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -62,7 +62,7 @@
 /sdk/identity/ @schaabs @daviwil @jonathandturner @sadasant
 
 # PRLabel: %KeyVault
-/sdk/keyvault/ @jonathandturner @sadasant
+/sdk/keyvault/ @jonathandturner @sadasant @maorleger
 
 # PRLabel: %Storage
 /sdk/storage/ @XiaoningLiu @jeremymeng @HarshaNalluru @vinjiang @jiacfan @ljian3377

diff --git a/.gitignore b/.gitignore
@@ -118,6 +118,7 @@ Thumbs.db
 *.cer
 *.pfx
 *.pem
+*.key
 
 # WebStorm #
 .idea/

diff --git a/sdk/keyvault/keyvault-admin/package.json b/sdk/keyvault/keyvault-admin/package.json
@@ -71,7 +71,7 @@
     "test:node": "npm run clean && npm run build:test && npm run unit-test:node",
     "test": "npm run clean && npm run build:test && npm run unit-test",
     "unit-test:browser": "echo skipped",
-    "unit-test:node": "echo skipped",
+    "unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace dist-test/index.node.js",
     "unit-test": "npm run unit-test:node && npm run unit-test:browser",
     "docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --stripInternal --mode file --out ./dist/docs ./src"
   },

diff --git a/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_createroleassignment.js b/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_createroleassignment.js
diff --git a/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_deleteroleassignment.js b/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_deleteroleassignment.js
diff --git a/...e/aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_getroleassignment.js b/...e/aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_getroleassignment.js
diff --git a/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroleassignments.js b/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroleassignments.js
diff --git a/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroledefinitions.js b/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroledefinitions.js
diff --git a/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js b/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js
diff --git a/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js b/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js
diff --git a/...ticate_tests/recording_should_skip_unexpected_properties_on_the_wwwauthenticate_header.js b/...ticate_tests/recording_should_skip_unexpected_properties_on_the_wwwauthenticate_header.js
diff --git a/...uthenticate_tests/recording_should_work_for_known_shapes_of_the_wwwauthenticate_header.js b/...uthenticate_tests/recording_should_work_for_known_shapes_of_the_wwwauthenticate_header.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -118,6 +118,7 @@ Thumbs.db @@
     *.cer
     *.pfx
     *.pem
+    *.key
     # WebStorm #
     .idea/
@@ Expand Down @@