Release 1.1.1 version preparation #9869
Conversation
mssfang
added
Client
mssfang
requested review from
alzimmermsft,
conniey,
danieljurek,
JimSuplizio,
mitchdenny,
sima-zhu and
weshaggard
as code owners
There was a problem hiding this comment.
@mssfang did you run the update_versions.py script? The reason your pipelines are failing is because the version of azure-data-appconfiguration in eng/jacoco-test-coverage/pom.xml wasn't updated in the PR and is still referencing the version that was current before your changes.
| @@ -17,20 +17,6 @@ Key concepts are explained in detail [here][SDK_README_KEY_CONCEPTS]. | |||
| ## Getting started | |||
| Getting started explained in detail [here][SDK_README_GETTING_STARTED]. | |||
|
|
|||
| ### Adding the package to your project | |||
There was a problem hiding this comment.
/CC @alzimmermsft
I don't think this should have been removed. "Adding the package..." should be changed to "Include the package" and the version should have been updated to 1.1.1
There was a problem hiding this comment.
Discussed offline, removing this from the samples README should be fine given that AppConfiguration was the odd on out for including this. Will follow-up around this during the release postmortem to get guidelines in place for the samples READMEs as we do for the root README.
|
@JimSuplizio I ran "python eng\versioning\update_versions.py --update-type library --build-type client". And only included the AppConfig changes. For "### Adding the package to your project", I checked other SDKs, they don't include this section in the Sample Readme, so i will stay consistency with it. |
The plan moving forward is to use |
Fixes: #9868