Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update EnvironmentCredential and azure.core.util.Configuration #9682

Merged
merged 13 commits into from
Apr 2, 2020
Merged

update EnvironmentCredential and azure.core.util.Configuration #9682

merged 13 commits into from
Apr 2, 2020

Conversation

cxznmhdcxz
Copy link
Member

@cxznmhdcxz cxznmhdcxz commented Mar 30, 2020

Updated EnvironmentCredential to support env vars for UsernamePasswordCredential and ClientCertificateCredential. Added PROPERTY_AZURE_CLIENT_CERTIFICATE_PATH to azure.core.util.Configuration.

same code as #7337, as #7337 was reverted

@alzimmermsft
Copy link
Member

This build is failing since Identity is relying on the released version of Azure Core and these changes depend on source code Azure Core, this is why the Identity from source validation job is passing but all others are failing. To fix this the dependency version of Azure Core will need to be changed to unreleased_com.azure:azure-core.

@g2vinay
Copy link
Member

g2vinay commented Mar 31, 2020

Rebase with master.
and update core dependency to this

<dependency>
  <groupId>com.azure</groupId>
  <artifactId>azure-core</artifactId>
  <version>1.4.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->
</dependency>

@g2vinay g2vinay merged commit 5a2baca into Azure:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants