-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update EnvironmentCredential and azure.core.util.Configuration #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxznmhdcxz
requested review from
alzimmermsft,
anuchandy,
g2vinay,
hemanttanwar,
jianghaolu,
schaabs and
srnagar
as code owners
March 30, 2020 08:02
This build is failing since Identity is relying on the released version of Azure Core and these changes depend on source code Azure Core, this is why the Identity from source validation job is passing but all others are failing. To fix this the dependency version of Azure Core will need to be changed to |
Rebase with master.
|
…vironmentCredential
g2vinay
reviewed
Apr 1, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
schaabs
approved these changes
Apr 2, 2020
srnagar
reviewed
Apr 2, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Apr 2, 2020
g2vinay
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated EnvironmentCredential to support env vars for UsernamePasswordCredential and ClientCertificateCredential. Added PROPERTY_AZURE_CLIENT_CERTIFICATE_PATH to azure.core.util.Configuration.
same code as #7337, as #7337 was reverted