Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnvVar AZURE_AUTHORITY_HOST #9392

Merged
merged 7 commits into from
Apr 2, 2020
Merged

Add EnvVar AZURE_AUTHORITY_HOST #9392

merged 7 commits into from
Apr 2, 2020

Conversation

Luyunmt
Copy link
Contributor

@Luyunmt Luyunmt commented Mar 23, 2020

Added EnvVar AZURE_AUTHORITY_HOST to azure.identity._constants.
TokenCredentialOptions has an AuthorityHost property.
This will be modified to support EnvVar override with AZURE_AUTHORITY_HOST.
/issues/5967

@Luyunmt Luyunmt marked this pull request as ready for review March 23, 2020 10:23
@tzhanl tzhanl requested a review from jongio March 23, 2020 11:15
@jongio
Copy link
Member

jongio commented Mar 27, 2020

Can you please add tests?

@jongio jongio mentioned this pull request Mar 30, 2020
Merged
@tzhanl tzhanl changed the base branch from FixENVVars to master March 31, 2020 02:19
@g2vinay
Copy link
Member

g2vinay commented Mar 31, 2020 •
edited
Loading

Rebase with master.
and change the core dependency in azure-identity/pom.xml to this:

<dependency>
  <groupId>com.azure</groupId>
  <artifactId>azure-core</artifactId>
  <version>1.4.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->
</dependency>

@g2vinay g2vinay merged commit 6edef4f into Azure:master Apr 2, 2020
@Luyunmt Luyunmt mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@schaabs schaabs schaabs approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@jongio jongio Awaiting requested review from jongio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Luyunmt @jongio @g2vinay @schaabs @alzimmermsft @srnagar