Identity credential Bug Fixes #8765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2020 10:22
g2vinay
requested review from
jongio,
jianghaolu,
srnagar,
JonathanGiles and
schaabs
jongio
approved these changes
Mar 5, 2020
jianghaolu
approved these changes
Mar 5, 2020
srnagar
reviewed
Mar 6, 2020
|
|
||
| /** | ||
| * Specifies the ExecutorService to be used to execute the requests. | ||
| * Developer is responsible for maintaining the lifecycle of the ExecutorService. |
There was a problem hiding this comment.
When does the developer shutDown() the ExecutorService? Could you please elaborate the documentation on how and when the user should use this and when to shut it down? Also, would be great to have some samples for this.
srnagar
approved these changes
Mar 6, 2020
jianghaolu
approved these changes
Mar 6, 2020
|
/azp run java - identitiy - ci |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8626