Prototype for Service Bus Track 2 Queue Receiver/Sender #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 29, 2020 15:59
…feature/servicebus-track2-queuec-client-draft-implementation-7697
hemanttanwar
changed the title
hemanttanwar
commented
Feb 12, 2020
...us/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/MessageBatch.java
Outdated
Show resolved
Hide resolved
conniey
requested changes
Feb 13, 2020
eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ClientConstants.java
Outdated
Show resolved
Hide resolved
...ssaging-servicebus/src/main/java/com/azure/messaging/servicebus/implementation/Messages.java
Show resolved
Hide resolved
...ging-servicebus/src/main/java/com/azure/messaging/servicebus/implementation/SendOptions.java
Outdated
Show resolved
Hide resolved
...icebus/src/main/java/com/azure/messaging/servicebus/implementation/ServiceBusProperties.java
Outdated
Show resolved
Hide resolved
...ure-messaging-servicebus/src/test/java/com/azure/messaging/servicebus/AsyncReceiverTest.java
Outdated
Show resolved
Hide resolved
...azure-messaging-servicebus/src/test/java/com/azure/messaging/servicebus/AsyncSenderTest.java
Outdated
Show resolved
Hide resolved
hemanttanwar
requested review from
alzimmermsft,
anuchandy,
danieljurek,
jianghaolu,
JimSuplizio,
mitchdenny and
mssfang
as code owners
JimSuplizio
approved these changes
Feb 24, 2020
…aft-implementation-7697
Move classes in to model folder. Update Message and remove unneeded methods. Rename MessageBatch.java -> ServiceBusMessageBatch Add missing properties to ServiceBusMessage. Updating serialization logic for service bus.
Add receive options into receive processor. Adding message processor for ServiceBus. Fix name of ServiceBusSender. Updating default method to PEEK_LOCK Adding integration test. Add deserialization test. Updating logging for sender and adding parameters for send test. Adding Mono.empty() so it does not nul reference
conniey
reviewed
Mar 2, 2020
...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/RequestResponseChannel.java
Outdated
Show resolved
Hide resolved
…into hemanttanwar/feature/servicebus-track2-queuec-client-draft-implementation-7697
conniey
changed the title
conniey
approved these changes
Mar 5, 2020
JonathanGiles
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft/ Prototype for Service Bus Track 2
• Three separate Client for Queue, Topic and Subscriber
• Each client have its own builder
• No Separate Client for basic V/s advance features users
Pro:
Con:
Duplication of API, more public API footprint.
Features Considered
All the options for API design are discussed here.
#8044
PS: I will work on check style and spotbugs suppressions now.