Removed AZURE_LOG_LEVEL:3 from test.yml in AzConfig which caused azure core to fail. #7914
Conversation
mssfang
commented
Feb 3, 2020
•
mssfang
commented
- 'AZURE_LOG_LEVEL: 3' which caused nightly live tests to failed on HttpLoggingPolicyTests in azure core.
- In addition, removed unnecessary slf4j log dependency.
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssfang
requested review from
alzimmermsft,
conniey,
danieljurek and
sima-zhu
as code owners
mssfang
added
Client
mssfang
changed the title
| @@ -10,4 +10,3 @@ jobs: | |||
| AZURE_CLIENT_ID: $(aad-azure-sdk-test-client-id) | |||
| AZURE_CLIENT_SECRET: $(aad-azure-sdk-test-client-secret) | |||
| AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id) | |||
| AZURE_LOG_LEVEL: 3 | |||
There was a problem hiding this comment.
This shouldn't have been removed as it was pointing to a real issue with HttpLoggingPolicy.
There was a problem hiding this comment.
+1 to Srikanta's comment. Logging shouldn't affect whether a test passes or fails.
There was a problem hiding this comment.
created an issue to azure-core: #7919
There was a problem hiding this comment.
KeyVault and Storage don't use AZURE_LOG_LEVEL in test.yml file. So I think azure core changes should not block Azconfig's nightly live tests.
There was a problem hiding this comment.
Event Hubs uses AZURE_LOG_LEVEL. It helps a lot in understanding what in the SDK went wrong during a test rather than getting no spew at all.
The original reason we added AZURE_LOG_LEVEL was because we were trying to understand what was going wrong in the live tests because they were encountering a 429. The error could not be reproduced on our dev machines, but in the build machines. So, setting this log level would hopefully shed some light on the errors happening in the SDK.
There was a problem hiding this comment.
This is some limitation on test setup. In HttpLoggingPolicyTests, we have set the environment variable using System.setProperty, but this one will be overwritten if there is environment variable setup in system.
The HttpLoggingPolicyTests is working fine on AZURE_LOG_LEVEL<=2.
There was a problem hiding this comment.
The current workaround is to set AZURE_LOG_LEVEL to 2 if log is needed in live tests
|
Edited I suggest you revert this merge and submit a new PR for discussion. |
…e core to fail. (Azure#7914) * delete slf4j dependency * remove log level
