-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure BufferedResponse type is not caching un-released buffer #7837
Conversation
The issue:The consumers of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Not certain either if my suggestions will work but something to think about applying (and for future coding efforts to cut down on verbosity).
sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/BufferedHttpResponse.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/BufferedHttpResponse.java
Outdated
Show resolved
Hide resolved
@srnagar thanks for the review. @JonathanGiles, thanks - your suggestions work, validated locally so committing them. |
…n/http/BufferedHttpResponse.java Co-Authored-By: Jonathan Giles <[email protected]>
…n/http/BufferedHttpResponse.java Co-Authored-By: Jonathan Giles <[email protected]>
…#7837) * Making BufferedResponse to do deep caching (it was doing shallow caching) * Make BufferedResponse really buffer and updating decoder to not to use BufferedResponse * Update sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/BufferedHttpResponse.java Co-Authored-By: Jonathan Giles <[email protected]> * Update sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/BufferedHttpResponse.java Co-Authored-By: Jonathan Giles <[email protected]> Co-authored-by: Jonathan Giles <[email protected]>
No description provided.