Fixed bug where root directory client could not be used to create files #7748
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
alzimmermsft,
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
rickle-msft
reviewed
Jan 27, 2020
| @@ -134,6 +134,9 @@ public ShareServiceVersion getServiceVersion() { | |||
| */ | |||
| public ShareFileAsyncClient getFileClient(String fileName) { | |||
| String filePath = directoryPath + "/" + fileName; | |||
| if (directoryPath.isEmpty()) { | |||
| filePath = fileName; | |||
There was a problem hiding this comment.
Can you add a comment that this is to accommodate the root?
rickle-msft
approved these changes
Jan 27, 2020
alzimmermsft
approved these changes
Jan 28, 2020
samvaity
pushed a commit
to samvaity/azure-sdk-for-java
that referenced
this pull request
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6592