Guava Version Downgrade to 25.0-jre #7628
Conversation
…at method from version 27.0.1-jre
| @@ -552,4 +557,91 @@ public ValueHolder(V v) { | |||
| holder.v = dictionary.remove(key); | |||
| return holder.v != null; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Lets please get clarification on required claims context from OSS
There was a problem hiding this comment.
Waiting for PR to be approved, and then will start the OSS process.
Just want to make sure these changes are good and don't pose any hidden faults before starting the OSS process.
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JimSuplizio , @danieljurek , @mitchdenny |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
@kushagraThapar these changes aren't correct. You know that versions are not changed directly in the POM, they're either changes in the version_*.txt files in the case of built libraries or the external_dependencies.txt file in the case of external dependencies. The file you should have changed is external_dependencies.txt and then you should have run python eng/versioning/update_versions.py --ut external_dependency --sr from the root of the enlistment. This is the reason that the Analyze step is failing.
As for the checkout errors, if you were missing a configuration you would not have had ANY runs passing. @mitchdenny could this be because the pipelines are using v1 style git tasks (If you look at the last post on that thread it's someone else seeing a similar issue posted a few days ago).
@JimSuplizio Thank you Jim for correcting me here, I will update the external_dependencies.txt file and run the script and push my changes |
kushagraThapar
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
Apparently when we're running these runs it's merging your changes on top of master to run. When you see the git exit code of 128 that means that your branch is more than 20 commits behind master. The correct course of action here would be to rebase master and push an updated PR. |
|
Waiting for CELA requirements to be fulfilled. Please don't merge this PR until then. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Strings.lenientFormat()from guava library to azure cosmos internalUtils.java