Adding Transport client request life cycle timeline on diagnostics #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar and
moderakh
as code owners
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
reviewed
Jan 30, 2020
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestTimeline.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
reviewed
Feb 5, 2020
...smos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/http/ReactorNettyClient.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
LGTM.
Just it is worth if @David-Noble-at-work also could take a look too. as David did some work in both rntbd and diagnostics his input will be valuable.
kushagraThapar
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
LGTM, let' wait for @David-Noble-at-work 's review on this.
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java
Show resolved
Hide resolved
David-Noble-at-work
approved these changes
Feb 7, 2020
...c/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestRecord.java
Show resolved
Hide resolved
|
issue have been open as an extention to this PR #8035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add timeline for various stage of transport client request on diagnostics, both on Direct mode(Rntbd) or in Gateway (ReactorNettyHttp).
Below how it looks on diagnostics string
Rntbd protocol -
"transportRequestTimeline": [
{
"eventName": "created",
"startTime": "2020-02-04T14:54:59.488-05:00",
"durationInMicroSec": "51000"
},
{
"eventName": "queued",
"startTime": "2020-02-04T14:54:59.539-05:00",
"durationInMicroSec": "266000"
},
{
"eventName": "pipelined",
"startTime": "2020-02-04T14:54:59.805-05:00",
"durationInMicroSec": "9990000"
},
{
"eventName": "transitTime",
"startTime": "2020-02-04T14:55:09.795-05:00",
"durationInMicroSec": "50000"
},
{
"eventName": "received",
"startTime": "2020-02-04T14:55:09.845-05:00",
"durationInMicroSec": "20000"
},
{
"eventName": "completed",
"startTime": "2020-02-04T14:55:09.865-05:00",
"durationInMicroSec": "0"
}
]
Http protocol -
"transportRequestTimeline": [
{
"eventName": "connectionCreated",
"startTime": "2020-02-04T14:53:47.932-05:00",
"durationInMicroSec": "78000"
},
{
"eventName": "connectionConfigured",
"startTime": "2020-02-04T14:53:48.010-05:00",
"durationInMicroSec": "1000"
},
{
"eventName": "requestSent",
"startTime": "2020-02-04T14:53:48.011-05:00",
"durationInMicroSec": "2000"
},
{
"eventName": "transitTime",
"startTime": "2020-02-04T14:53:48.013-05:00",
"durationInMicroSec": "51000"
},
{
"eventName": "received",
"startTime": "2020-02-04T14:53:48.064-05:00",
"durationInMicroSec": "1000"
}
]