Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Tests #7296

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jan 9, 2020

Fixes tests that were failing when running against the Storage service.

  • A few tests were previously relying on a hard-coded default of 4MB which was recently changed to be a user controlled value which now defaults to 256MB, these tests are now passing 4MB for the user controlled value.
  • The upload from file code path was altered to eagerly validate ParallelTransferOptions which resulted in it failing a check whether HTBB transfer could be applied. Logic was changed to maintain the original state long enough to make this validation to use HTBB when able.
  • One test could result in Reactor returning different exceptions, a composite exception can be thrown from a flatMap is multiple streams hit an exception instead of returning a single exception. Testing logic was updated to expand the composite exception and do deep validation.

@alzimmermsft alzimmermsft self-assigned this Jan 9, 2020
@alzimmermsft alzimmermsft marked this pull request as ready for review January 9, 2020 17:36
@alzimmermsft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

@rickle-msft Mind giving this PR a review? It should resolve a few testing issues and ensures that HTBB upload is being properly applied in the upload from file case.

@alzimmermsft alzimmermsft merged commit 53333b4 into Azure:master Jan 9, 2020
@alzimmermsft alzimmermsft deleted the AzStorage_BlockBlobAPITestFixes branch January 9, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants