Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Disabled tests in Text Analytics #7061

Merged
merged 5 commits into from
Dec 27, 2019
Merged

Update for Disabled tests in Text Analytics #7061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dcc76f
update test records for errors
samvaity Dec 27, 2019
a39935f
update
samvaity Dec 27, 2019
c2ed582
update test records for errors
samvaity Dec 27, 2019
3856590
Merge branch 'update-test-errors' of https://github.com/samvaity/azur…
samvaity Dec 27, 2019
9062e04
update detect lanaguage
samvaity Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import com.azure.ai.textanalytics.models.TextSentimentClass;
import com.azure.core.exception.HttpResponseException;
import com.azure.core.util.Context;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import reactor.test.StepVerifier;

Expand All @@ -37,7 +36,6 @@ protected void beforeTest() {
}

// Detected Languages

/**
* Verify that we can get statistics on the collection result when given a batch input with options.
*/
Expand Down Expand Up @@ -136,7 +134,6 @@ public void detectLanguageFaultyText() {
* Verifies that a Bad request exception is returned for input documents with same ids.
*/
@Test
@Disabled
public void detectLanguageDuplicateIdInput() {
detectLanguageDuplicateIdRunner((inputs, options) -> {
StepVerifier.create(client.detectBatchLanguagesWithResponse(inputs, options, Context.NONE))
Expand All @@ -163,7 +160,7 @@ public void recognizeEntitiesForEmptyText() {
.verifyComplete();
}

@Override
@Test
public void recognizeEntitiesForFaultyText() {
// TODO: (savaity) confirm with service team this returns no error-ed document, no exception but empty documents and error list.
StepVerifier.create(client.recognizeEntities("!@#%%"))
Expand Down Expand Up @@ -289,7 +286,7 @@ public void recognizePiiEntitiesForEmptyText() {
.verifyComplete();
}

@Override
@Test
public void recognizePiiEntitiesForFaultyText() {
// TODO: (savaity) confirm with service team this returns no error-ed document, no exception but empty documents and error list.
StepVerifier.create(client.recognizePiiEntities("!@#%%"))
Expand Down
4 changes: 0 additions & 4 deletions ...re-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import com.azure.ai.textanalytics.models.TextAnalyticsError;
import com.azure.core.exception.HttpResponseException;
import com.azure.core.util.Context;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.util.Arrays;
Expand Down Expand Up @@ -131,7 +130,6 @@ public void detectLanguageInvalidCountryHint() {
* Verifies that a Bad request exception is returned for input documents with same ids.
*/
@Test
@Disabled
public void detectLanguageDuplicateIdInput() {
detectLanguageDuplicateIdRunner((inputs, options) -> {
assertRestException(() -> client.detectBatchLanguagesWithResponse(inputs, options, Context.NONE),
Expand All @@ -155,7 +153,6 @@ public void recognizeEntitiesForEmptyText() {
}

@Test
@Disabled
public void recognizeEntitiesForFaultyText() {
// TODO: (savaity) confirm with service team.
assertEquals(client.recognizeEntities("!@#%%").getNamedEntities().size(), 0);
Expand Down Expand Up @@ -189,7 +186,6 @@ public void recognizePiiEntitiesForEmptyText() {
}

@Test
@Disabled
public void recognizePiiEntitiesForFaultyText() {
assertEquals(client.recognizePiiEntities("!@#%%").getNamedEntities().size(), 0);
}
Expand Down
2 changes: 1 addition & 1 deletion ...e-ai-textanalytics/src/test/resources/session-records/detectLanguageDuplicateIdInput.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"networkCallRecords" : [ {
"Method" : "POST",
"Uri" : "https://javatextanalyticstestresources.cognitiveservices.azure.com/text/analytics/v3.0-preview.1/languages?showStats=true",
"Uri" : "https://javatextanalyticstestresources.cognitiveservices.azure.com/text/analytics/v3.0-preview.1/languages",
"Headers" : {
"User-Agent" : "azsdk-java-azure-ai-textanalytics/1.0.0-beta.1 (11.0.4; Windows 10 10.0)",
"x-ms-client-request-id" : "aabc5399-ae00-4ead-8ead-bca8b1989d7d",
Expand Down
27 changes: 25 additions & 2 deletions ...e-ai-textanalytics/src/test/resources/session-records/recognizeEntitiesForFaultyText.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@
{
"networkCallRecords" : [ ],
"networkCallRecords" : [ {
"Method" : "POST",
"Uri" : "https://javatextanalyticstestresources.cognitiveservices.azure.com/text/analytics/v3.0-preview.1/entities/recognition/general",
"Headers" : {
"User-Agent" : "azsdk-java-azure-ai-textanalytics/1.0.0-beta.1 (11.0.5; Windows 10 10.0)",
"x-ms-client-request-id" : "ea8835bd-4259-4867-9c01-e1845882c1bf",
"Content-Type" : "application/json; charset=utf-8"
},
"Response" : {
"Transfer-Encoding" : "chunked",
"x-envoy-upstream-service-time" : "29",
"Strict-Transport-Security" : "max-age=31536000; includeSubDomains; preload",
"x-content-type-options" : "nosniff",
"csp-billing-usage" : "CognitiveServices.TextAnalytics.BatchScoring=1",
"apim-request-id" : "64334c9b-a767-419f-b5d0-cfb331a405e8",
"x-aml-ta-request-id" : "84ca812c-7b19-48b3-b254-8b27ac149336",
"retry-after" : "0",
"StatusCode" : "200",
"Body" : "{\"documents\":[{\"id\":\"0\",\"entities\":[]}],\"errors\":[],\"modelVersion\":\"2019-10-01\"}",
"Date" : "Fri, 27 Dec 2019 22:10:43 GMT",
"Content-Type" : "application/json; charset=utf-8"
},
"Exception" : null
} ],
"variables" : [ ]
}
}
27 changes: 25 additions & 2 deletions ...i-textanalytics/src/test/resources/session-records/recognizePiiEntitiesForFaultyText.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@
{
"networkCallRecords" : [ ],
"networkCallRecords" : [ {
"Method" : "POST",
"Uri" : "https://javatextanalyticstestresources.cognitiveservices.azure.com/text/analytics/v3.0-preview.1/entities/recognition/pii",
"Headers" : {
"User-Agent" : "azsdk-java-azure-ai-textanalytics/1.0.0-beta.1 (11.0.5; Windows 10 10.0)",
"x-ms-client-request-id" : "5e42a69b-f818-42d2-8720-25e6c136e0cc",
"Content-Type" : "application/json; charset=utf-8"
},
"Response" : {
"Transfer-Encoding" : "chunked",
"x-envoy-upstream-service-time" : "26",
"Strict-Transport-Security" : "max-age=31536000; includeSubDomains; preload",
"x-content-type-options" : "nosniff",
"csp-billing-usage" : "CognitiveServices.TextAnalytics.BatchScoring=1",
"apim-request-id" : "29e4f8de-9b8a-496f-bbf2-c3cbea8c0fff",
"x-aml-ta-request-id" : "12f4043a-d75f-4516-bcaf-19d7b163c30d",
"retry-after" : "0",
"StatusCode" : "200",
"Body" : "{\"documents\":[{\"id\":\"0\",\"entities\":[]}],\"errors\":[],\"modelVersion\":\"2019-10-01\"}",
"Date" : "Fri, 27 Dec 2019 22:07:03 GMT",
"Content-Type" : "application/json; charset=utf-8"
},
"Exception" : null
} ],
"variables" : [ ]
}
}
1 change: 0 additions & 1 deletion sdk/textanalytics/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ jobs:
ServiceDirectory: textanalytics
EnvVars:
AZURE_TEST_MODE: RECORD
AZURE_TEXT_ANALYTICS_SUBSCRIPTION_KEY: $(java-textanalytics-test-subscription-key)
AZURE_CLIENT_ID: $(aad-azure-sdk-test-client-id)
AZURE_CLIENT_SECRET: $(aad-azure-sdk-test-client-secret)
AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id)
Expand Down