Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Blob Test Reliability #6566

Merged
merged 28 commits into from
Dec 11, 2019
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
897eb39
Updating tests to enhance reliability
alzimmermsft Nov 26, 2019
1a137c1
Merge branch 'master' into AzStorage_EnhanceTestReliability
alzimmermsft Nov 26, 2019
ca90f15
Add hook to prevent additional logging
alzimmermsft Nov 26, 2019
752d21b
Merge branch 'master' into AzStorage_EnhanceTestReliability
alzimmermsft Nov 27, 2019
1f73dab
Print statement to help with reliability debugging
alzimmermsft Nov 27, 2019
984a5f2
Remove some blocking calls
alzimmermsft Nov 27, 2019
668e717
Removing more blocking calls in favor of StepVerifier
alzimmermsft Nov 27, 2019
e23ea12
Updating playback records
alzimmermsft Nov 27, 2019
081f419
Merge branch 'master' into AzStorage_EnhanceTestReliability
alzimmermsft Nov 27, 2019
a091a56
Revert on error resume and fixed linting issue
alzimmermsft Nov 27, 2019
fed3c6a
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
sima-zhu Dec 5, 2019
064bd0f
Added retry limits and concurrency limits
sima-zhu Dec 5, 2019
af55be6
change log level back to error
sima-zhu Dec 5, 2019
e525d06
change log level back to error
sima-zhu Dec 6, 2019
d5c4c88
Remove extra retry
sima-zhu Dec 6, 2019
e907330
Make small changes to detect the issue
sima-zhu Dec 6, 2019
dfcbf8a
Added some message
sima-zhu Dec 6, 2019
2f981ab
Print the system value
sima-zhu Dec 6, 2019
7c98879
Added sys value into commandline
sima-zhu Dec 6, 2019
b283463
literally setup
sima-zhu Dec 6, 2019
b9a323b
Remove invalid commands
sima-zhu Dec 6, 2019
455c694
Added retry back
sima-zhu Dec 6, 2019
ace585a
Remove the one failed at local
sima-zhu Dec 6, 2019
49b3d42
Remove debug
sima-zhu Dec 6, 2019
ad9e6b6
Remove logging info
sima-zhu Dec 7, 2019
426e70c
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
sima-zhu Dec 10, 2019
7619f5e
Make some changes to settings and pull mainline
sima-zhu Dec 10, 2019
1d5609d
Revert back the comment tests
sima-zhu Dec 11, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make some changes to settings and pull mainline
  • Loading branch information
sima-zhu committed Dec 10, 2019
commit 7619f5efff5ab6e73e929fcd1808d0fe4e8d0a85
2 changes: 1 addition & 1 deletion eng/pipelines/client.yml
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ resources:
endpoint: azure

variables:
DefaultOptions: '--batch-mode -Dmaven.wagon.http.pool=false --settings eng/settings.xml'
DefaultOptions: '--batch-mode --fail-at-end -Dmaven.wagon.http.pool=false --settings eng/settings.xml'
LoggingOptions: '-Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'

jobs:
Original file line number Diff line number Diff line change
@@ -141,9 +141,6 @@ class APISpec extends Specification {
alternateCredential = getCredential(SECONDARY_STORAGE)
blobCredential = getCredential(BLOB_STORAGE)
premiumCredential = getCredential(PREMIUM_STORAGE)
Properties props = System.getProperties()
props.setProperty("reactor.bufferSize.x", "16")
props.setProperty("reactor.bufferSize.small", "100")
}

def setup() {
@@ -155,7 +152,10 @@ class APISpec extends Specification {
this.testName = fullTestName.substring(0, substringIndex)
this.interceptorManager = new InterceptorManager(className + fullTestName, testMode)
this.resourceNamer = new TestResourceNamer(className + testName, testMode, interceptorManager.getRecordedData())

// The property is to limit flapMap buffer size of concurrency
// in case the upload or download open too many connections.
System.setProperty("reactor.bufferSize.x", "16")
System.setProperty("reactor.bufferSize.small", "100")
// If the test doesn't have the Requires tag record it in live mode.
recordLiveMode = specificationContext.getCurrentIteration().getDescription().getAnnotation(Requires.class) == null

@@ -172,6 +172,9 @@ class APISpec extends Specification {
}

def cleanup() {
System.clearProperty("reactor.bufferSize.x")
System.clearProperty("reactor.bufferSize.small")

def options = new ListBlobContainersOptions().setPrefix(containerPrefix + testName)
for (BlobContainerItem container : primaryBlobServiceClient.listBlobContainers(options, Duration.ofSeconds(120))) {
BlobContainerClient containerClient = primaryBlobServiceClient.getBlobContainerClient(container.getName())