ADLS gen1-gen2-mapping #6435
ADLS gen1-gen2-mapping #6435
Conversation
gapra-msft
requested review from
alzimmermsft,
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
|
Looking at this mapping would we want to add an exists method into Datalake? It exists (no pun intended) in Blobs, Files, and Queues and was functionality in the previous version. Were the create flags inverted in Datalake compared to Blobs? In Blobs it won't overwrite by default (unless that changed and I missed it) and it seems strange for two closely related SDKs to have such a difference. Should there be an API mapping comment for the remove ACL functions explaining how setAcl is capable of accomplishing this functionality (if this work similarly to how blobs and queues handle it). Were setExpiryTime and setTimes replaced with another API that encompasses their functionality? This is just general comments on the API and not for this PR. |
Yep, you're right! I created an issue for the exists method #6437 and the no overwrite by default is in my TODO list as well #6104. Also as far as I know set ACL just modifies existing ACLs, they dont work quite like blobs. |
| <td>checkExists</td> | ||
| <td>Check whether a file or directory exists.</td> | ||
| <td>N/A</td> | ||
| <td>Use Gen2 API methods <strong>createFileWithResponse</strong> and <strong>createDirectoryWithResponse</strong> and set <strong>BlobRequestConditions.setIfNoneMatch(true)</strong></td> |
There was a problem hiding this comment.
I think this needs to be setIfNoneMatch("*"). And didn't I also see you create an issue for adding an exists method()? That would be a better mapping
There was a problem hiding this comment.
You're right, thanks for that catch. And I created the two issues for exists and no overwrite default, we'll have to update the doc once those features exist
| <tr> | ||
| <td>createClient</td> | ||
| <td>Gets an ADLStoreClient object.</td> | ||
| <td><strong>DataLakeServiceClient.create</strong></td> |
There was a problem hiding this comment.
ServiceClientBuilder.build
| <td>createEmptyFile</td> | ||
| <td>Creates an empty file.</td> | ||
| <td><strong>DataLakeFileClient.create</strong></td> | ||
| <td>By default this method will override an existing file, set <strong>BlobRequestConditions.setIfNoneMatch(true)</strong> to prevent overwriting.</td> |
There was a problem hiding this comment.
"will overwrite"; ifNoneMatch("*")
| <td>getAclStatus</td> | ||
| <td>Queries the ACLs and permissions for a file or directory.</td> | ||
| <td><strong>DataLakeFileClient.getAccessControl</strong> and <strong>DataLakeDirectoryClient.getAccessControl</strong></td> | ||
| <td>Set <strong>ListPathsOptions.path</strong> to the desired path</td> |
There was a problem hiding this comment.
I don't think ListPathsOptions are relevant here
|
Created an issue to provide enumerateDirectory functionality #6442 |
No description provided.