Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose way to get EventHubConnection #6138

Merged
merged 5 commits into from
Nov 1, 2019
Merged

Conversation

conniey
Copy link
Member

@conniey conniey commented Nov 1, 2019

  • Exposes a way to create a shared connection through the builder
  • Add validation when creating EventHubConsumer
  • Hook up FQDN in EventHubClient
  • Update documentation
  • Fix live test failures

@conniey conniey self-assigned this Nov 1, 2019
@conniey conniey added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Nov 1, 2019
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conniey conniey closed this Nov 1, 2019
@conniey conniey reopened this Nov 1, 2019
@conniey conniey merged commit ca30bd3 into Azure:master Nov 1, 2019
@conniey conniey deleted the fix-connection branch November 1, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants