Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown for code of conduct and pr template #6053

Merged
merged 6 commits into from
Jan 22, 2020

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Oct 25, 2019

Add markdown for

  • Code of Conduct
  • PR template

fixes: #5936

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Infrastructure labels Oct 25, 2019
@mssfang mssfang self-assigned this Oct 25, 2019
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

@mssfang mssfang requested a review from joshfree October 29, 2019 17:54
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@mssfang mssfang requested a review from JonathanGiles January 16, 2020 19:21
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated feedback. I'd make this repo consistent with the existing code of conduct used in the Azure repo and the pull request template consistent with the template from the other Azure SDK repos

CODE_OF_CONDUCT.md Show resolved Hide resolved
@@ -0,0 +1,41 @@
#Azure SDK for Java Pull Request Template Guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the Azure SDK For .NET PULL_REQUEST_TEMPLATE.md as a template for the Java repo?

https://github.com/Azure/azure-sdk-for-net/blob/master/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md

The embedded links would need to be updated to point to resources in our repo, and those resources would also need to be added.

@mssfang mssfang requested a review from joshfree January 22, 2020 17:52
@mssfang mssfang requested a review from JonathanGiles January 22, 2020 17:53
@joshfree joshfree merged commit f6356fa into Azure:master Jan 22, 2020
@mssfang mssfang deleted the Community-Profile branch January 22, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address two community gaps
3 participants