Suppress LineLength for Track 1 #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run java-docs |
|
No pipelines are associated with this pull request. |
|
/azp run java - docs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - keyvault - data |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - eventhubs - data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vhvb1989
approved these changes
Sep 6, 2019
mssfang
reviewed
Sep 6, 2019
| <suppress checks="LineLength" files=".*[/\\]com[/\\]azure[/\\]storage[/\\]"/> | ||
|
|
||
| <!-- Suppress LineLength for Track 1 libraries. --> | ||
| <suppress checks="LineLength" files=".*[/\\]com[/\\]microsoft[/\\]"/> |
There was a problem hiding this comment.
Suggested change
| <suppress checks="LineLength" files=".*[/\\]com[/\\]microsoft[/\\]"/> | |
| <suppress checks="LineLength" files=".*[/\\]com[/\\]microsoft[/\\].*"/> |
There was a problem hiding this comment.
Not required. The regex will match still.
There was a problem hiding this comment.
We just want the regex to result in an isMatch when we evaluate a file name with it. The .* isn't needed to basically take anything else.
There was a problem hiding this comment.
To double check, the suppression line here basically does the logic. It looks for any match to that regex, then returns true or false if a match is found.
mssfang
reviewed
Sep 6, 2019
| <!-- Suppress lineLength for Storage on Preview 3. https://github.com/Azure/azure-sdk-for-java/issues/5125 --> | ||
| <suppress checks="LineLength" files=".*[/\\]com[/\\]azure[/\\]storage[/\\]*"/> | ||
| <!-- Suppress LineLength for Storage on Preview 3. https://github.com/Azure/azure-sdk-for-java/issues/5125 --> | ||
| <suppress checks="LineLength" files=".*[/\\]com[/\\]azure[/\\]storage[/\\]"/> |
There was a problem hiding this comment.
Suggested change
| <suppress checks="LineLength" files=".*[/\\]com[/\\]azure[/\\]storage[/\\]"/> | |
| <suppress checks="LineLength" files=".*[/\\]com[/\\]azure[/\\]storage[/\\].*"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress LineLength checkstyle rule for Track 1 libraries.