Adding rule for enforcing final field usage - DoNotMerge until all issues are fixed #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
approved these changes
Aug 15, 2019
eng/code-quality-reports/src/main/java/com/azure/tools/checkstyle/checks/Utils.java
Outdated
Show resolved
Hide resolved
eng/code-quality-reports/src/main/java/com/azure/tools/checkstyle/checks/Utils.java
Outdated
Show resolved
Hide resolved
eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
conniey
reviewed
Aug 15, 2019
...quality-reports/src/main/java/com/azure/tools/checkstyle/checks/EnforceFinalFieldsCheck.java
Outdated
Show resolved
Hide resolved
…yle/checks/Utils.java Co-Authored-By: Connie Yau <[email protected]>
…yle/checks/Utils.java Co-Authored-By: Connie Yau <[email protected]>
vhvb1989
requested review from
alzimmermsft,
hemanttanwar,
jianghaolu and
srnagar
as code owners
JonathanGiles
approved these changes
Aug 16, 2019
vhvb1989
requested review from
gapra-msft,
jaschrep-msft and
rickle-msft
as code owners
* Adding fixes for checkstyle enforce final fields * Adding suppressi for fields with default access
azure-sdk
pushed a commit
that referenced
this pull request
Jan 5, 2023
…" for perf.yml This reverts commit 81c78afd563a32c224eb45b0cf864078d55b68eb.
azure-sdk
pushed a commit
that referenced
this pull request
Jan 5, 2023
…" for perf.yml This reverts commit 81c78afd563a32c224eb45b0cf864078d55b68eb.
azure-sdk
added a commit
that referenced
this pull request
Jan 5, 2023
…" for perf.yml (#32788) This reverts commit 81c78afd563a32c224eb45b0cf864078d55b68eb. Co-authored-by: Mike Harder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked PRs for fixes: