Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StorageException a POJO #4924

Merged
merged 6 commits into from
Aug 16, 2019
Merged

Make StorageException a POJO #4924

merged 6 commits into from
Aug 16, 2019

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Aug 9, 2019 •
edited
Loading

Fixes #4539

  • Changed StorageException to a POJO class
  • Moved StorageException into the models package
  • Create StorageException class for Files and Queues

@alzimmermsft alzimmermsft changed the title Az storage make storage exception pojo Make StorageException a POJO Aug 9, 2019
@alzimmermsft alzimmermsft self-assigned this Aug 9, 2019
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Aug 9, 2019
sima-zhu
sima-zhu approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@sima-zhu sima-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft marked this pull request as ready for review August 12, 2019 21:38
@alzimmermsft alzimmermsft merged commit 41418b4 into Azure:master Aug 16, 2019
@alzimmermsft alzimmermsft deleted the AzStorage_MakeStorageExceptionPOJO branch August 16, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sima-zhu sima-zhu sima-zhu approved these changes

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@gapra-msft gapra-msft Awaiting requested review from gapra-msft

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StorageException should use POJO pattern.
2 participants
@alzimmermsft @sima-zhu