[Fix] CS-Rule: No external library in public API #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck for public class for external Dependency check
…into CS-Rule-ExternalDependency
…into CS-Rule-ExternalDependency
mssfang
requested review from
alzimmermsft,
danieljurek,
hemanttanwar,
jianghaolu,
mitchdenny,
srnagar and
weshaggard
as code owners
conniey
reviewed
Jul 26, 2019
...-reports/src/main/java/com/azure/tools/checkstyle/checks/ExternalDependencyExposedCheck.java
Show resolved
Hide resolved
|
Does this check handle a scenario such as |
vhvb1989
requested changes
Jul 26, 2019
...-reports/src/main/java/com/azure/tools/checkstyle/checks/ExternalDependencyExposedCheck.java
Outdated
Show resolved
Hide resolved
...-reports/src/main/java/com/azure/tools/checkstyle/checks/ExternalDependencyExposedCheck.java
Outdated
Show resolved
Hide resolved
eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
…into CS-Rule-ExternalDependency
alzimmermsft
approved these changes
Jul 26, 2019
conniey
approved these changes
Jul 27, 2019
conniey
reviewed
Jul 27, 2019
...-reports/src/main/java/com/azure/tools/checkstyle/checks/ExternalDependencyExposedCheck.java
Outdated
Show resolved
Hide resolved
Alan's point here is a good one. For example, ConfigurationClientCredentials has methods that take a |
JonathanGiles
approved these changes
Jul 28, 2019
…into CS-Rule-ExternalDependency
|
Refactored the code and created a recursion method that takes care of (1) TYPE as a root node, it can have IDENT and/or TYPE_AURGUMENTS as children nodes; (2) TYPE_AURGUMENT as a root node, it can have IDENT and/or TYPE_AURGUMENTS as children nodes; (3) TYPE_AURGUMENTS as a root node, it can have TYPE_AURGUMENT as child node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to No External Dependency check style rule. Previously, it fails only on the method's return type but not parameter types, and not checking on a protected class.
Also, remove unused import