Batch #2 - 11. No .builder() API: No classes should have a .builder() #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
conniey,
danieljurek,
hemanttanwar,
jaschrep-msft,
jianghaolu,
mitchdenny,
rickle-msft,
samvaity,
sima-zhu,
srnagar and
weshaggard
as code owners
conniey
reviewed
Jul 25, 2019
| <module name="MethodName"/> | ||
| <module name="MethodName"> | ||
| <!-- Use default MethodName but block the use of 'builder' as method name --> | ||
| <property name="format" value="(?=^[a-z][a-zA-Z0-9]*$)(?!^[b][uU][iI][lL][dD][eE][rR]$)"/> |
There was a problem hiding this comment.
Are mode specifiers available? It's easier to read ((?i)builder)$, imho.
There was a problem hiding this comment.
Yes, it is supported. I have tested and worked.
Thank you for it! 👍 Updated now
alzimmermsft
approved these changes
Jul 26, 2019
jianghaolu
approved these changes
Jul 26, 2019
g2vinay
approved these changes
Jul 26, 2019
| - * | ||
| - * @return A new {@link HttpPipelineBuilder} to create a HttpPipeline from. | ||
| */ | ||
| public HttpPipelineBuilder() { |
There was a problem hiding this comment.
Can you please fix up the javadoc here. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add MethodName rule to disable builder as a method name and update isssues
You might want to see checkstyle.xml for MethodName rule update. Then everything else is fixing what we had already with a builder()