Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tracing context in Key Vault secrets package #4549

Merged
merged 15 commits into from
Jul 31, 2019
Merged

Add Tracing context in Key Vault secrets package #4549

merged 15 commits into from
Jul 31, 2019

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Jul 23, 2019 •
edited
Loading

  • Added tracing context to Keyvault secrets package
  • Added T with Response<T> "overload in sync and async Key vault secretsclient.
  • Updated tests if necessary to work with the new return types.

Closes: #4476

@samvaity samvaity self-assigned this Jul 23, 2019
@joshfree joshfree requested a review from g2vinay July 25, 2019 21:45
@samvaity samvaity marked this pull request as ready for review July 26, 2019 17:55
@danieljurek danieljurek mentioned this pull request Jul 26, 2019
Merged
@samvaity samvaity mentioned this pull request Jul 26, 2019
Merged
JonathanGiles
JonathanGiles requested changes Jul 29, 2019
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go through with an eye to reduce duplication, simplify, and to standardise naming.

...re-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java Outdated Show resolved Hide resolved
...re-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java Outdated Show resolved Hide resolved
...re-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java Outdated Show resolved Hide resolved
...re-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java Outdated Show resolved Hide resolved
@samvaity samvaity requested a review from mssfang as a code owner July 29, 2019 18:50
@samvaity samvaity requested a review from JonathanGiles July 29, 2019 23:20
@samvaity samvaity requested a review from JonathanGiles July 30, 2019 21:47
g2vinay
g2vinay reviewed Jul 31, 2019
View reviewed changes
.../azure-keyvault-secrets/src/samples/java/com/azure/security/keyvault/secrets/HelloWorld.java
@@ -36,14 +36,14 @@ public static void main(String[] args) throws InterruptedException, IllegalArgum
.expires(OffsetDateTime.now().plusYears(1)));
Copy link
Member

@g2vinay g2vinay Jul 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a couple of samples showing usage of Response < T > in Hello World area.
Processing the headers info + secret info
Doesn't have to be everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KeyVault API responses don't seem to have a lot of information on the headers that could be useful for showing in samples.
I just added something that could validate the operation using the status code information in
the response.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is fine for now, the goal is to show the use of Response
extracting key , and looking at whatever header info is given.

@g2vinay
Copy link
Member

g2vinay commented Jul 31, 2019 •
edited
Loading

@JonathanGiles ,
Do we have some central documentation for users explaining Response < T > return type.
It would be nice point users somewhere in the javadocs for methods with Response< T > return types.

@JonathanGiles
Copy link
Member

@JonathanGiles ,
Do we have some central documentation for users explaining Response return type.
It would be nice point users somewhere in the javadocs for methods with Response return types.

Not at present. I would like to initially have this in our wiki which I have slowly been setting up here. Feel free to add new pages and links - we can flesh the whole thing out between now and GA.

@samvaity samvaity merged commit 0c12ca0 into Azure:master Jul 31, 2019
@samvaity samvaity deleted the tracing-secrets branch September 27, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g2vinay g2vinay g2vinay approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@joshfree joshfree joshfree approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@samvaity samvaity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tracing support in Key Vault secrets package
5 participants
@samvaity @g2vinay @JonathanGiles @joshfree @alzimmermsft