Update Storage to azure-core preview 3 #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue
Removes RawClients from Storage Blobs
…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient
|
Closing in favor of #4489 |
* Initial check in for storage queue
…-for-java into storage-swagger
* Finished the restructure, refactor builder. Added sleep in record feature. Linting
…-for-java into storage-swagger
Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed.
…-for-java into storage-swagger
jianghaolu
requested review from
jaschrep-msft,
mitchdenny,
rickle-msft,
samvaity and
weshaggard
as code owners
alzimmermsft
approved these changes
Jul 26, 2019
jianghaolu
commented
Jul 29, 2019
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method", | ||
| "x-ms-skip-url-encoding": true |
There was a problem hiding this comment.
James will discuss with team
jianghaolu
commented
Jul 29, 2019
| @@ -3219,8 +3382,10 @@ | |||
| "format": "etag" | |||
| }, | |||
| "Quota": { | |||
| "type": "integer", | |||
| "format": "int64", | |||
| "type": "integer" | |||
There was a problem hiding this comment.
James to discuss with team
jianghaolu
commented
Jul 29, 2019
| @@ -98,7 +98,7 @@ | |||
| public BlockBlobAsyncClient asBlockBlobAsyncClient() { | |||
| return new BlockBlobAsyncClient(new AzureBlobStorageBuilder() | |||
| .url(getBlobUrl().toString()) | |||
| .pipeline(azureBlobStorage.httpPipeline()), snapshot); | |||
| .pipeline(azureBlobStorage.getHttpPipeline()), snapshot); | |||
There was a problem hiding this comment.
Jianghao to start discussion with James and Jonathan
jaschrep-msft
approved these changes
Jul 29, 2019
sima-zhu
approved these changes
Jul 29, 2019
g2vinay
reviewed
Jul 29, 2019
| https://github.com/azure/azure-sdk-for-java/issues/4556 --> | ||
| <Match> | ||
| <Or> | ||
| <Class name="com.azure.security.keyvault.keys.KeyClient"/> |
There was a problem hiding this comment.
how was this spotbug issue resolved?
There was a problem hiding this comment.
This was brought in from merge - will revert.
…-java into storage-swagger
joshfree
approved these changes
Jul 29, 2019
JonathanGiles
approved these changes
Jul 29, 2019
| @@ -21,14 +21,14 @@ | |||
| * <p>Create a pipeline without configuration</p> | |||
| * | |||
| * <pre> | |||
| * HttpPipeline.builder() | |||
| * new HttpPipelineBuilder() | |||
| * .build(); | |||
There was a problem hiding this comment.
nit: Move the .build() onto the same line.
| if (snapshot != null) { | ||
| urlBuilder.query("snapshot=" + snapshot); | ||
| } | ||
| return urlBuilder.toURL(); | ||
| } catch (MalformedURLException e) { | ||
| throw new RuntimeException(String.format("Invalid URL on %s: %s" + getClass().getSimpleName(), azureBlobStorage.url()), e); | ||
| throw new RuntimeException(String.format("Invalid URL on %s: %s" + getClass().getSimpleName(), azureBlobStorage.getUrl()), e); |
There was a problem hiding this comment.
FYI: This will very shortly result in CheckStyle check failure, as the clientLogger.logAndThrow API should be used instead. The PR for this is soon to be merged here: #4566
|
We discussed this in our storage sync today and this can be merged now with follow up issues opened for the two follow ups:
|
g2vinay
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.