Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial checkin for Storage file #4414

Merged
merged 33 commits into from
Jul 24, 2019
Merged

Initial checkin for Storage file #4414

Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e43a8b2
Finished the restructure, refactor builder. Added sleep in record fea…
sima-zhu Jul 12, 2019
b7c446b
Fixed the macOS
sima-zhu Jul 12, 2019
889ec07
merge from mainlnie
sima-zhu Jul 12, 2019
8334cb1
Added commit for macOS and linux for debuging the filepath
sima-zhu Jul 12, 2019
3a6470b
Fixed filePath
sima-zhu Jul 12, 2019
0ae0d8a
Remove comments
sima-zhu Jul 12, 2019
bddf4da
Keep the download file.
sima-zhu Jul 13, 2019
ca12657
Added the empty download file.
sima-zhu Jul 13, 2019
cdfeb09
Fixed the failure test in linux and mac
Jul 14, 2019
740e7e1
Fixed the upload download tests.
sima-zhu Jul 16, 2019
456deb3
Fixed the record and playback tests
sima-zhu Jul 16, 2019
b1ea3be
Fix checkstyle
sima-zhu Jul 16, 2019
7c0f87d
URL and snapshot refactor. FileService JavaDoc code snippet done.
sima-zhu Jul 18, 2019
f98107e
Fixed the failed JavaDoc
sima-zhu Jul 18, 2019
6f729e0
Share client java doc code snippet.
sima-zhu Jul 19, 2019
93a5fce
Directory client java doc code snippet.
sima-zhu Jul 19, 2019
e5f1ec7
file
sima-zhu Jul 19, 2019
efb304b
file client java doc code snippet
sima-zhu Jul 20, 2019
f6853df
Merge branch 'storage-post-review1-dev' into storage-file
sima-zhu Jul 22, 2019
67410a8
CLean up the javadoc snippet
sima-zhu Jul 22, 2019
a65ed6d
Merge branch 'storage-file' of https://github.com/sima-zhu/azure-sdk-…
sima-zhu Jul 22, 2019
67aee2a
Addressed comments
sima-zhu Jul 22, 2019
6047a3f
Addressed the comments from PR
sima-zhu Jul 22, 2019
9ceb72b
Fixed README
sima-zhu Jul 22, 2019
ddb43c1
Addressed the comments from PR and meeting,
sima-zhu Jul 23, 2019
bd80931
Addressed the comments from PR and meeting.
sima-zhu Jul 23, 2019
b615c23
Add file version.
sima-zhu Jul 23, 2019
1f83cb2
Fixed the playback test
sima-zhu Jul 23, 2019
738677a
Update storage/client/file/src/main/java/com/azure/storage/file/Direc…
sima-zhu Jul 23, 2019
d673190
Make changes to javadoc and readme
sima-zhu Jul 23, 2019
ca039a0
Merge branch 'storage-file' of https://github.com/sima-zhu/azure-sdk-…
sima-zhu Jul 23, 2019
434123e
Changed the log level to warning and make it non-static
sima-zhu Jul 23, 2019
67e7fcb
Remove the duplicate exclude rule in spotbugs
sima-zhu Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@
<Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE"/>
</Match>

<Match>
<Class name="~com\.azure\.(.+)Impl"/>
<Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE"/>
</Match>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't duplicate the pattern - put it in the Or clause above instead.


<!-- Public field already exists in the public API surface area even though no writes were seen to this public field.
https://github.com/Azure/azure-sdk-for-java/blob/master/eventhubs/data-plane/azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/BatchOptions.java#L50
https://github.com/Azure/azure-sdk-for-java/blob/master/eventhubs/data-plane/azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/BatchOptions.java#L57 -->
Expand Down Expand Up @@ -368,6 +373,7 @@
<Match>
<Or>
<Package name="com.microsoft.azure.storage.blob"/>
<Package name="com.azure.storage.file.models"/>
<Class name="com.azure.storage.blob.HTTPGetterInfo"/>
</Or>
<Bug pattern="NM_CONFUSING"/>
Expand Down
7 changes: 7 additions & 0 deletions eng/spotbugs-aggregate-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<azure-keyvault.version>4.0.0-preview.1</azure-keyvault.version>
<azure-messaging-eventhubs.version>5.0.0-preview.2</azure-messaging-eventhubs.version>
<azure-storage.version>12.0.0-preview.1</azure-storage.version>
<azure-storage-file.version>12.0.0-preview.1</azure-storage-file.version>
<azure-storage-queue.version>12.0.0-preview.1</azure-storage-queue.version>
</properties>
<distributionManagement>
Expand Down Expand Up @@ -183,6 +184,12 @@
<!-- <artifactId>azure-storage-blob</artifactId>-->
<!-- <version>${azure-storage.version}</version>-->
<!-- </dependency>-->

<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-file</artifactId>
<version>${azure-storage-file.version}</version>
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-queue</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions pom.client.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,10 @@
<title>Azure Storage - Blobs</title>
<packages>com.azure.storage.blob*</packages>
</group>
<group>
<title>Azure Storage - Files</title>
<packages>com.azure.storage.file*</packages>
</group>
<group>
<title>Azure Storage - Queues</title>
<packages>com.azure.storage.queue*</packages>
Expand Down Expand Up @@ -753,6 +757,7 @@
<!-- <module>./sdk/tracing</module>-->
<module>./sdk/identity/azure-identity</module>
<module>./storage/client/blob</module>
<module>./storage/client/file</module>
<module>./storage/client/queue</module>
</modules>
</project>
1 change: 0 additions & 1 deletion ...t-secrets/src/main/java/com/azure/security/keyvault/secrets/KeyVaultErrorCodeStrings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,3 @@ private static synchronized void loadProperties() {
}



5 changes: 2 additions & 3 deletions storage/client/blob/src/samples/java/FileTransferExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.RandomAccessFile;
import java.net.URL;
Expand Down Expand Up @@ -139,7 +138,7 @@ private static File createTempEmptyFile(String fileName) throws IOException {
}
}

private static void createTempFileWithFileSize(File f, long size) throws FileNotFoundException, IOException {
private static void createTempFileWithFileSize(File f, long size) throws IOException {
RandomAccessFile raf = new RandomAccessFile(f, "rw");
raf.setLength(size);
raf.close();
Expand All @@ -148,7 +147,7 @@ private static void createTempFileWithFileSize(File f, long size) throws FileNot
private static void checkTwoFilesAreTheSame(File f1, File f2) throws IOException, NoSuchAlgorithmException {
String checksumUpload = getFileChecksum(f1);
String checksumDownload = getFileChecksum(f2);
if (checksumUpload.equals(checksumDownload)) {
if (!checksumUpload.equals(checksumDownload)) {
throw new RuntimeException("The file upload does not match the file download.");
}
}
Expand Down
Loading