Harden VertxRequestWriteSubsriber #43402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
|
API change check API changes are not detected in this pull request. |
srnagar
approved these changes
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Outdated
Show resolved
Hide resolved
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Show resolved
Hide resolved
anuchandy
approved these changes
Dec 13, 2024
...src/test/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriberTests.java
Outdated
Show resolved
Hide resolved
joshfree
approved these changes
Dec 13, 2024
...src/test/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriberTests.java
Show resolved
Hide resolved
...src/test/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriberTests.java
Outdated
Show resolved
Hide resolved
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Show resolved
Hide resolved
lmolkova
reviewed
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Show resolved
Hide resolved
lmolkova
reviewed
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Show resolved
Hide resolved
lmolkova
reviewed
Dec 13, 2024
...ertx/src/main/java/com/azure/core/http/vertx/implementation/VertxRequestWriteSubscriber.java
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #43399
Hardens the logic in
VertxRequestWriteSubsriberto make is less brittle if thePromisebeing used in completed or failed externally to the class.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines