-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, network, bug fix on bastion resource in subnet ipconf #43082
Merged
weidongxu-microsoft
merged 5 commits into
Azure:main
from
weidongxu-microsoft:mgmt_network-bug-fix-bastion-in-subnet
Nov 26, 2024
Merged
mgmt, network, bug fix on bastion resource in subnet ipconf #43082
weidongxu-microsoft
merged 5 commits into
Azure:main
from
weidongxu-microsoft:mgmt_network-bug-fix-bastion-in-subnet
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
This issue is related to a management-plane library.
label
Nov 25, 2024
API change check API changes are not detected in this pull request. |
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
November 26, 2024 02:18
XiaofeiCao
reviewed
Nov 26, 2024
...nager-network/src/main/java/com/azure/resourcemanager/network/implementation/SubnetImpl.java
Outdated
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test?
I've added a test case for bastion https://github.com/Azure/azure-sdk-for-java/pull/43082/files#diff-323edf5682fe51f9f310ee479a68db1a799a2c43fee5777600edfc9f99b35774 |
XiaofeiCao
approved these changes
Nov 26, 2024
weidongxu-microsoft
deleted the
mgmt_network-bug-fix-bastion-in-subnet
branch
November 26, 2024 05:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #43070
Filter out resource that is not
Microsoft.Network/networkInterfaces
.Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines