-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logic to avoid block call under non blocking thread #43063
Merged
moarychan
merged 9 commits into
Azure:main
from
moarychan:bugfixes/improve-logic--to-avoid-block-call-under-non-blocking-thread
Nov 22, 2024
Merged
Improve logic to avoid block call under non blocking thread #43063
moarychan
merged 9 commits into
Azure:main
from
moarychan:bugfixes/improve-logic--to-avoid-block-call-under-non-blocking-thread
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
moarychan
requested review from
rujche,
Netyyyy and
saragluna
as code owners
November 22, 2024 03:28
saragluna
reviewed
Nov 22, 2024
...zure-core/src/main/java/com/azure/spring/integration/core/handler/DefaultMessageHandler.java
Show resolved
Hide resolved
saragluna
reviewed
Nov 22, 2024
...zure-core/src/main/java/com/azure/spring/integration/core/handler/DefaultMessageHandler.java
Outdated
Show resolved
Hide resolved
...venthubs/src/test/java/com/azure/spring/messaging/eventhubs/core/EventHubsTemplateTests.java
Show resolved
Hide resolved
…re/spring/integration/core/handler/DefaultMessageHandler.java Co-authored-by: Xiaolu Dai <[email protected]>
saragluna
reviewed
Nov 22, 2024
saragluna
approved these changes
Nov 22, 2024
moarychan
deleted the
bugfixes/improve-logic--to-avoid-block-call-under-non-blocking-thread
branch
November 26, 2024 07:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick from #40772
Issues #12500, #35845 and #35215 appear to be due to
EventHubsTemplate.doSend
performing ablock()
call. When used by the non-async methods inEventHubsTemplate
, or the async methods when a non-parallel ReactorScheduler
is being used, this will work well enough. But when using a parallel ReactorScheduler
, blocking calls are prohibited.This PR restructures the code in
EventHubsTemplate.doSend
to not use a blocking call. A test was added first to verify that we could detect this condition by performing one of the existing test cases withScheduler.parallel()
. After the changes toEventHubsTemplate
, this test passes.And fix the same issue for
DefaultMessageHandler.handleMessageInternal
.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines