refactorInsecureConnectionConfig #42972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
hallipr,
weshaggard,
benbp,
JimSuplizio,
kirankumarkolli and
a team
as code owners
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Show resolved
Hide resolved
...c/test/java/com/azure/cosmos/rx/changefeed/pkversion/IncrementalChangeFeedProcessorTest.java
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
xinlian12
force-pushed
the
refactorInsecureConnectionConfig
branch
from
ab9849f to
ed15e41
Compare
|
/check-enforcer override |
JimSuplizio
approved these changes
Nov 18, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR #42912, we added a config to allow using insecure connections for emulator. In this PR, we are splitting the config into three different system properties so we can have a more granular config.
using
COSMOS.HTTP_CONNECTION_WITHOUT_TLS_ALLOWEDorCOSMOS_HTTP_CONNECTION_WITHOUT_TLS_ALLOWEDto allow http connection against emulator.Using
COSMOS.EMULATOR_SERVER_CERTIFICATE_VERIFICATION_DISABLEDorCOSMOS_EMULATOR_SERVER_CERTIFICATE_VERIFICATION_DISABLEDto disable cert verification for emulator.Using
COSMOS.EMULATOR_HOSTorCOSMOS_EMULATOR_HOSTto config the emulator host name. By default it will try to match withlocalhostor127.0.0.1or[::1]or[0:0:0:0:0:0:0:1].