allowUsingHttp2 #42947
Merged
allowUsingHttp2 #42947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
force-pushed
the
enableHttp2ForTest
branch
from
128a645 to
e3939b3
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...os/src/main/java/com/azure/cosmos/implementation/http/Http2ResponseHeaderCleanerHandler.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/http/HttpClient.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Looks good overall, thanks @xinlian12
I added few suggestions!
...os/src/main/java/com/azure/cosmos/implementation/http/Http2ResponseHeaderCleanerHandler.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/http/HttpClient.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
|
Flaky tests: readFeedDocumentsAfterSplit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMOS.HTTP2_ENABLEDand system variableCOSMOS_HTTP2_ENABLEDCOSMOS.HTTP2_MAX_CONNECTION_POOL_SIZEand system variableCOSMOS_HTTP2_MAX_CONNECTION_POOL_SIZECOSMOS.HTTP2_MIN_CONNECTION_POOL_SIZEand system variableCOSMOS_HTTP2_MIN_CONNECTION_POOL_SIZECOSMOS.HTTP2_MAX_CONCURRENT_STREAMSand system variableCOSMOS_HTTP2_MAX_CONCURRENT_STREAMS