[test] face API with enable-subclient #42875
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Nov 20, 2024
Link Azure/autorest.java#2972 Current limitation - sub client need to be in same namespace of its parent. Feature behind `enable-subclient` option (`false` means client/operationGroup; `true` means all client, with client having accessor to get subclient) unbranded openai https://github.com/joseharriaga/openai-in-typespec ## Bug to be fixed in other PRs (relate to unbranded openai, but unrelated to this feature -- moved to #5047) - #5026 - #5030 - #5028 - #5031 ## Test 1. cadl-ranch PR Azure/cadl-ranch#727 (also tried on test with more than 2 level subclient -- nested namespaces) 2. openai unbranded https://github.com/joseharriaga/openai-in-typespec/compare/main...weidongxu-microsoft:java-sub-client?expand=1 ([apiview](https://apiview.dev/Assemblies/Review/b974bacf316c495aa5c30ce0b7e07b1c/d1d7278c251d4805b189fd238714897d#com.openai.OpenAIClient)) 3. Face API Azure/azure-sdk-for-java#42875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable-subclientis added in my local, hence Analysis CI won't pass.Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines