Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Blobs Sync Stack Migration (#40812)" (#41819) #41968

Merged
merged 34 commits into from
Oct 17, 2024

Conversation

ibrahimrabab
Copy link
Contributor

This reverts commit ac9ee63.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Sep 20, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 20, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-storage-blob

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab ibrahimrabab marked this pull request as ready for review September 26, 2024 18:12
@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a few quick comments. I still need to go through the rest of the updates, but it is looking good.

Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had a couple more comments and we should be about set.

Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab
Copy link
Contributor Author

/azp run java - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ibrahimrabab
Copy link
Contributor Author

/check-enforcer override

@ibrahimrabab ibrahimrabab merged commit 5e1a8d7 into Azure:main Oct 17, 2024
28 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants