-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "Blobs Sync Stack Migration (#40812)" (#41819) #41968
Reapply "Blobs Sync Stack Migration (#40812)" (#41819) #41968
Conversation
This reverts commit ac9ee63.
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
…ere, adding tests for copy api in BlobApiTests
…to restoreBlobsSyncMigration
…to restoreBlobsSyncMigration
…to restoreBlobsSyncMigration
…to restoreBlobsSyncMigration
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
…to restoreBlobsSyncMigration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a few quick comments. I still need to go through the rest of the updates, but it is looking good.
eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml
Outdated
Show resolved
Hide resolved
...zure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlockBlobAsyncClient.java
Show resolved
Hide resolved
…changes made to module-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just had a couple more comments and we should be about set.
...azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/ModelHelper.java
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerClient.java
Show resolved
Hide resolved
…to restoreBlobsSyncMigration
...rage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobClientBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚢
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
…to restoreBlobsSyncMigration
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer override |
This reverts commit ac9ee63.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines