Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure identity sample for Event Hubs README #4188

Merged
merged 6 commits into from
Jun 28, 2019

Conversation

conniey
Copy link
Member

@conniey conniey commented Jun 28, 2019

  • Adds an Azure identity sample using ClientSecretCredential
  • Changes the absolute links to relative
  • Organizes the links at the bottom.

@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jun 28, 2019
@conniey conniey self-assigned this Jun 28, 2019
eventhubs/client/README.md Outdated Show resolved Hide resolved

All the implemented ways to get a credential can be found under the `com.azure.identity.credential` package. The sample below shows how to use an Azure Active Directory (AAD) application client secret to authorize with Azure Event Hubs.

#### Authorizing with AAD application client secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: did you mean for this to have 3 "#"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to have 4. The 3rd level header is "Create an Event Hub client using Microsoft identity platform (formerly Azure Active Directory)", and this next section builds off of that previous one.

@mssfang mssfang mentioned this pull request Jun 28, 2019
@conniey conniey merged commit 7d423c6 into Azure:master Jun 28, 2019
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Jun 29, 2019
* Adding an example to authorize with AAD.

* Fix broken links

* Fixing link.

* Sort links

* Make links relative

* Review changes.
@conniey conniey deleted the aad-readme branch September 9, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants