Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kv Javadoc Plugin update #4178

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Kv Javadoc Plugin update #4178

merged 5 commits into from
Jun 28, 2019

Conversation

g2vinay
Copy link
Member

@g2vinay g2vinay commented Jun 28, 2019

Kv javadoc plugin grouping update in pom.client.xml

@g2vinay g2vinay requested a review from JonathanGiles June 28, 2019 02:53
@g2vinay g2vinay self-assigned this Jun 28, 2019
@g2vinay g2vinay requested a review from srnagar June 28, 2019 16:08
@@ -0,0 +1,5 @@
# Release History
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using uppercase filename CHANGELOG to be consistent with other files like README, CONTRIBUTING, LICENSE etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed.
But some SDKs like Batch and Cosmos were using lowercase.
Lets go uppercase as that's the standard.

@g2vinay g2vinay merged commit f736ebc into Azure:master Jun 28, 2019
sima-zhu pushed a commit that referenced this pull request Jun 29, 2019
Added Release notes + KV javadoc grouping update
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Jun 29, 2019
Added Release notes + KV javadoc grouping update
@g2vinay g2vinay deleted the keyvault-update branch July 13, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants