Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple bugs in AzurePowerShellCredential #41254

Closed
wants to merge 6 commits into from
Closed

Fix a couple bugs in AzurePowerShellCredential #41254

wants to merge 6 commits into from

Conversation

billwert
Copy link
Contributor

@billwert billwert commented Jul 23, 2024 •
edited
Loading

Newer versions of Az.Accounts have a warning about an upcoming change to Get-AzAccessToken. This breaks the existing parsing. In addition, there's a breaking change coming to Get-AzAccessToken which will make the Token field a SecureString. So a few fixes:

  1. Suppress warnings on the command we get JSON from. We'll still fail for real errors.
  2. Start passing -AsSecureString to Get-AzAccessToken (and unpack it for our use.)
  3. I noticed in a previous PR I got the order of Windows arguments wrong and probably broke this credential on Windows. Fixing that.

Fixes #41234

@billwert billwert requested review from g2vinay, joshfree and a team as code owners July 23, 2024 23:53
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@billwert
Copy link
Contributor Author

/azp run azure - identity - tests

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@billwert
Copy link
Contributor Author

/azp run java - identity

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@billwert billwert closed this Jul 24, 2024
@billwert billwert reopened this Jul 24, 2024
@billwert
Copy link
Contributor Author

/azp run java - identity

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@billwert billwert closed this Jul 24, 2024
@joshfree
Copy link
Member

I noticed in a previous PR I got the order of Windows arguments wrong and probably broke this credential on Windows. Fixing that.

Sounds like a good smoke test to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AzurePowerShellCredential fails to generate token due to deprecation message in Az 12.1.0
3 participants
@billwert @azure-sdk @joshfree