Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README and samples #4114
README and samples #4114
Changes from 10 commits
fbfe724
21aeea0
7412994
602e830
a0341b1
0ef429b
f5edabd
06fc5f8
d1d5d27
4c80be3
1eb7b35
3dde055
21f5b13
368f4e9
72e1909
278e734
34c7e67
e3fecce
f1d03bd
42c8a40
37f2d77
d7348cf
60e66c5
e8c226a
4f9acc0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Shouldn't these be in a
try/finally
block to prevent leaking in the face of exceptions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we don't care about the exception from close() in the sample. It applies to all the samples we have. But need double check with @conniey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that calling producer.send.block will throw an exception or countdown.await(), and even if those throw an exception,. you want to dispose of the subscription, so use try/finally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add two cents to that, if samples are to be the model for what we consider best practices, I would think it important to show a structure where there are no leaks and things that need to be closed/disposed are. In the worst case, I'd argue that we have an obligation to at least add a descriptive comment to that effect about how these should be closed and real-world code should expect exceptions and react appropriately.