Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cognitive services to sdk #4107

Merged
merged 13 commits into from
Jul 12, 2019

Conversation

mitchdenny
Copy link
Contributor

This PR moves all of the data-plane/track 1 cog services APIs into the /sdk folder. Under the original folder structure the libraries were placed in sub directories (e.g. langauage, vision etc). In the new structure the modules have been lifted into the /sdk/cognitiveservices for consistency with the other code bases that are being moved in under /sdk. Additionally the directories have been renamed to match the package name with a prefix of microsoft- to make room for track 2 libraries in the future.

@mitchdenny
Copy link
Contributor Author

/azp run java - cognitiveservices - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny marked this pull request as ready for review June 26, 2019 00:11
@mitchdenny mitchdenny self-assigned this Jun 26, 2019
@mitchdenny mitchdenny requested a review from jianghaolu June 26, 2019 17:03
@mitchdenny
Copy link
Contributor Author

@jianghaolu looks like this move will intersect with your PR #3415. Your PR has been outstanding since April are you still planning on merging it?

@mitchdenny mitchdenny requested a review from JonathanGiles July 2, 2019 18:48
@mitchdenny
Copy link
Contributor Author

Hey @JonathanGiles not sure if you want to look at this one also. In this case I flattened the folder hierarchy for consistency, but I suspect that in time we might break these out into their own separate service folders (so think of cog services as a family of services rather than a service outright).

@JonathanGiles
Copy link
Member

It's the same situation here as in #4087, where this pre-dates the ADP team.

@mitchdenny
Copy link
Contributor Author

Referencing this parent POM tidy up issue for tracking purposes: #4289

sdk/cognitiveservices/pom.xml Outdated Show resolved Hide resolved
sdk/cognitiveservices/pom.xml Outdated Show resolved Hide resolved
@mitchdenny mitchdenny force-pushed the move-cognitive-services-to-sdk branch from 19bfd2d to 17472fc Compare July 9, 2019 15:58
@mitchdenny mitchdenny requested a review from JonathanGiles July 11, 2019 21:54
eng/.docsettings.yml Show resolved Hide resolved
sdk/cognitiveservices/pom.xml Outdated Show resolved Hide resolved
@mitchdenny mitchdenny force-pushed the move-cognitive-services-to-sdk branch from 8d0f95d to 5b7cdca Compare July 12, 2019 15:48
@mitchdenny mitchdenny merged commit 5be8d7f into Azure:master Jul 12, 2019
@mitchdenny mitchdenny deleted the move-cognitive-services-to-sdk branch July 12, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants