Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpubsub-client test using endpoint #40726

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jun 20, 2024

Avoid connection string in test.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

weidongxu-microsoft and others added 3 commits June 26, 2024 09:57
…om/azure/messaging/webpubsub/client/TestBase.java

Co-authored-by: Srikanta <[email protected]>
…om/azure/messaging/webpubsub/client/TestBase.java

Co-authored-by: Srikanta <[email protected]>
@weidongxu-microsoft weidongxu-microsoft merged commit cde7e0e into Azure:main Jun 28, 2024
19 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the webpubsub-client_test-use-endpoint branch June 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants