Use no custom header APIs when header type isn't used #40482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates many service client APIs to use the
NoCustomHeaders
generated API. TheNoCustomHeaders
variant doesn't convert the response HTTP headers into a typed object, the service client APIs moved to these variants didn't use the custom headers being returned by the non-NoCustomHeaders
variant. Aka, they were wasting CPU cycles on converting the HTTP headers to a Java type just to throw away that work. This should provide a performance improvement.Additionally, the thread pool being used internally by Storage SDKs was replaced by
SharedExecutorService
inazure-core
. This is preferable as this is meant to be anExecutorService
shared by all Azure SDKs so that each SDK doesn't need to configure, and possible expose ways to modify the behavior, their ownExecutorService
s. Long term this will allow forazure-core
to simply provide better integration into application environments such as allowing theSharedExecutorService
to use anExecutorService
provided by the application rather than one in the implementation details ofazure-core
(allowing customers to better manage how the Azure SDKs use resources).All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines