Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage queue from Alan's PR #4036

Closed
wants to merge 138 commits into from
Closed
Show file tree
Hide file tree
Changes from 136 commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
5082438
Majority of client and testing structure
alzimmermsft May 30, 2019
6bfa0b0
Reshaping methods
alzimmermsft May 30, 2019
a991f24
Reset upstream to storage-proto
alzimmermsft May 30, 2019
13eec1b
Rough unit tests for Queue clients
alzimmermsft May 31, 2019
f59d502
More unit tests for Queue clients, some restructuring
alzimmermsft May 31, 2019
ab33289
Timeout is now used client side only throw Reactor's timeout
alzimmermsft May 31, 2019
3db312b
Manual changes to Auto REST code for compile reasons, beginning scaff…
alzimmermsft Jun 4, 2019
80153a2
Added QueueServiceClients
alzimmermsft Jun 4, 2019
710d8cc
Added QueueServiceClients
alzimmermsft Jun 4, 2019
d265fdd
Removed unit tests for initial PR
alzimmermsft Jun 4, 2019
fe57bfa
Turning off fail build on linting errors for initial implementation
alzimmermsft Jun 4, 2019
d9b6bbc
Updating clients to standardize with other languages
alzimmermsft Jun 4, 2019
75a28cd
Added temporary service annotation to the service interfaces
alzimmermsft Jun 4, 2019
300dadc
Turned off POC blob test
alzimmermsft Jun 4, 2019
3b28219
Removed Raw clients
alzimmermsft Jun 5, 2019
22e32f5
Removed context from sync clients and changed list to iterable
alzimmermsft Jun 5, 2019
d1ce6e8
Removing Context from all methods, cleaned up scoping
alzimmermsft Jun 5, 2019
764e6cb
Prototype of merged clients
alzimmermsft Jun 6, 2019
044b3b2
Pull and merged in changes from upstream
alzimmermsft Jun 6, 2019
64625d7
Fixed builder issues and added rudimentary JavaDocs
alzimmermsft Jun 6, 2019
f3c8f06
Added URL parsing for SAS token
alzimmermsft Jun 6, 2019
1e46e4b
Added SharedKeyCredential and policy
alzimmermsft Jun 6, 2019
ebb0d81
Renamed SharedKey to SASToken to properly reflect what the class is
alzimmermsft Jun 6, 2019
1181a67
Added SAS token and SharedKey credentials
alzimmermsft Jun 7, 2019
fcc7308
More URL manipulation in the builder
alzimmermsft Jun 7, 2019
5fb171d
Moved credential creation from query params and connection string to …
alzimmermsft Jun 7, 2019
83e1846
Fix recursion issue
alzimmermsft Jun 7, 2019
5315982
JavaDocs and Checkstyles, fixing SAS token parsing
alzimmermsft Jun 7, 2019
3248745
Updated fail on Checkstyles and JavaDocs
alzimmermsft Jun 7, 2019
1fc2fa1
Fix SAS token creation
alzimmermsft Jun 7, 2019
472102c
Added dequeue convenience method, scaffolding for unit tests
alzimmermsft Jun 7, 2019
c6540a9
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
alzimmermsft Jun 7, 2019
15c7bb7
More units tests, fixed listQueuesSegments, fixed SharedKey authoriza…
alzimmermsft Jun 10, 2019
fe46421
Final tests for QueueServiceClient
alzimmermsft Jun 11, 2019
74ed144
Playback mode session records, updated Javadocs for new overloads
alzimmermsft Jun 11, 2019
1bb1e5e
Some tests for QueueClient
alzimmermsft Jun 11, 2019
aaa1c7d
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
alzimmermsft Jun 12, 2019
c2d1c7c
Finalizing unit tests
alzimmermsft Jun 13, 2019
e1439ff
Updating playback records
alzimmermsft Jun 13, 2019
4fab228
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
alzimmermsft Jun 13, 2019
e93c63b
Merged in upstream
alzimmermsft Jun 14, 2019
3e8e568
Fixing playback unit tests
alzimmermsft Jun 14, 2019
bf6dad2
Changes based on feedback
alzimmermsft Jun 14, 2019
9ff7c28
Added auto page enumeration for listing queues, turned off list queue…
alzimmermsft Jun 15, 2019
40e177d
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
alzimmermsft Jun 17, 2019
50faad9
Fixes for PR playback
alzimmermsft Jun 17, 2019
955672f
Fixed forgetting to step client values in live mode
alzimmermsft Jun 17, 2019
0154afc
Centralizing client builders and fixing more PR playback issues
alzimmermsft Jun 17, 2019
90dfb90
Fixing unit tests
alzimmermsft Jun 17, 2019
be2ac22
Using Impl builder to construct the client
alzimmermsft Jun 18, 2019
7b4d671
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
alzimmermsft Jun 20, 2019
6f6d336
Changes based on PR feedback
alzimmermsft Jun 20, 2019
3afae03
Added code snippets and clean up the code
sima-zhu Jun 29, 2019
9856fc4
Update more dependencies (#4020)
weshaggard Jun 20, 2019
248a409
Kv secrets samples and readme (#3892)
g2vinay Jun 20, 2019
9a57ab3
Keys Samples (#4022)
g2vinay Jun 20, 2019
22c29ed
removing spotbug issues (#4033)
hemanttanwar Jun 21, 2019
bbfdb44
Batch REST API Update - June 2019 (#3861)
bgklein Jun 21, 2019
7e42e16
Azure core fix for storage playback tests. (#4035)
sima-zhu Jun 21, 2019
ec95c0a
Track 2: Event Hubs Client Library (#3655)
conniey Jun 21, 2019
7e6fd14
Fix OffsetDateTime parsing in IdentityClient (#4031)
jianghaolu Jun 21, 2019
a8be98f
Event Hubs: Build break fix, multiple connection and CBS nodes, hangi…
conniey Jun 23, 2019
02e6334
Event Hubs Samples (#4053)
conniey Jun 24, 2019
7fd418f
Fixing bug where the lastRefreshInterval was not properly set. (#4069)
conniey Jun 24, 2019
af68457
generated v2018_03_01 of redis (#4073)
iscai-msft Jun 24, 2019
0b83213
Cost Management: generated v2018_05_31 (#4076)
iscai-msft Jun 24, 2019
c4a9106
Identity Library Updates (#4061)
g2vinay Jun 24, 2019
064da3a
generated v2018_06_30 of automation (#3888)
iscai-msft Jun 24, 2019
cadbf79
Add ci.yml for eventgrid. (#4085)
mitchdenny Jun 24, 2019
626c373
MySql: generated v2017_12_01_preview (#4082)
iscai-msft Jun 24, 2019
f538bcd
PostgreSql: generated v2017_12_01_preview (#4084)
iscai-msft Jun 24, 2019
287557c
Fix javadoc description and package groups (#4074)
srnagar Jun 24, 2019
d8cffe5
generated v2018_04_01 and v2012_12_01_preview of IoTHub (#4088)
iscai-msft Jun 24, 2019
4e64a50
Prep for move of keyvault track 1 libs. (#4093)
mitchdenny Jun 24, 2019
56cf6f5
Adding Event Hubs integration and Unit Tests (#4089)
conniey Jun 24, 2019
4d52b40
Adding other status (#4091)
hemanttanwar Jun 25, 2019
607708e
Publish code coverage results for track 2 build pipelines only (#4096)
srnagar Jun 25, 2019
e9bce28
Eventhubs: generated v2017_04_01, v2015_08_01, and v2018_01_01_previe…
iscai-msft Jun 25, 2019
91c8651
Update client runtime v1 version to 1.6.10 (#4072)
praries880 Jun 25, 2019
106786a
generated v2018_07_01_preview policyinsights (#3374)
iscai-msft Jun 25, 2019
c381d26
generated v2016_11_01 of storageimportexport (#4092)
iscai-msft Jun 25, 2019
319c1b4
generated v2016_06_01 of recoveryservices, fixed build error (#3315)
iscai-msft Jun 25, 2019
3e2b62e
generated v2019_05_01 of machinelearningservices (#4101)
iscai-msft Jun 25, 2019
0515152
Netapp 2019-05-01 and 2017-08-15 (#3508)
iscai-msft Jun 25, 2019
70a8fa8
Adds appinsights ci setup in advance of refactoring. (#3925)
mitchdenny Jun 25, 2019
2312e42
Setup cognitive services CI. (#4106)
mitchdenny Jun 25, 2019
ea70315
updated azure-arm-parent versioning
iscai-msft Jun 25, 2019
9d7e811
generated v2018_07_01_preview of logic (#4112)
iscai-msft Jun 25, 2019
77419e5
Removing azure-core-auth package (#4104)
schaabs Jun 26, 2019
61bdca8
Adding CONTRIBUTING.md and update version number (#4113)
conniey Jun 26, 2019
f12c903
generated v2018_08_01 of network (#4120)
iscai-msft Jun 26, 2019
6ede17a
updated pom versioning (#4121)
iscai-msft Jun 26, 2019
6050497
generated v2015_03_20 of loganalytics (#4122)
iscai-msft Jun 26, 2019
04d31b8
generated v2015_11_01_preview of operationsmanagement (#4123)
iscai-msft Jun 26, 2019
70d303e
updated azure-arm-parent versioning (#4124)
iscai-msft Jun 26, 2019
28860df
Add Javadocs and code snippets (#4119)
conniey Jun 26, 2019
f170c05
Keyvault Updates (#4062)
g2vinay Jun 26, 2019
4d80982
Resourcehealth (#4142)
iscai-msft Jun 26, 2019
8f17c71
Javadoc updates (#4143)
conniey Jun 26, 2019
42d354f
Added CI configuration files. (#4150)
mitchdenny Jun 26, 2019
d967764
Cleanup Azure Core Fluent Method Names (#4149)
alzimmermsft Jun 27, 2019
38df5f7
More tests and limiting the delivery credits from 8000 to 100. (#4135)
conniey Jun 27, 2019
eee7de1
README and samples (#4114)
mssfang Jun 27, 2019
441410f
Add more SCM info
jianghaolu Jun 27, 2019
7490012
[maven-release-plugin] prepare release v1.0.0-preview.1
jianghaolu Jun 27, 2019
0a28789
[maven-release-plugin] prepare for next development iteration
jianghaolu Jun 27, 2019
f047f50
Azure core 1.0.0-preview.1 (#4165)
jianghaolu Jun 27, 2019
a8228da
Identity-Bug-Fix (#4141)
g2vinay Jun 27, 2019
e0df8f6
update links and link contents (#4166)
mssfang Jun 27, 2019
0435b63
Adding support for generating the azure-core-test JavaDoc (#4177)
JonathanGiles Jun 27, 2019
a3a3c81
Identity preview 1 version bump (#4170)
jianghaolu Jun 28, 2019
8a8d242
generated v2018_05_01 of policy (#4169)
iscai-msft Jun 28, 2019
d9639cb
Servicebus (#4159)
iscai-msft Jun 28, 2019
00fcd74
generated v2017_04_01 of servicebus (#3363)
iscai-msft Jun 28, 2019
8fc5051
Authorization (#4168)
iscai-msft Jun 28, 2019
f06b70f
generated v2018_02_01 of servicefabric (#4161)
iscai-msft Jun 28, 2019
7c7f043
Monitor (#4108)
iscai-msft Jun 28, 2019
ccd014c
generated v2017_04_01 of relay (#4140)
iscai-msft Jun 28, 2019
a767579
Search: generated v2015_02_28 (#4145)
iscai-msft Jun 28, 2019
f114f4e
Appconfiguration v2019 02 01 (#4182)
iscai-msft Jun 28, 2019
6137b5a
Initial design for blocking operation (#4134)
hemanttanwar Jun 28, 2019
c8b524e
Adding changelog.md (#4187)
conniey Jun 28, 2019
5cfbf64
Kv Javadoc Plugin update (#4178)
g2vinay Jun 28, 2019
f2bff76
generated v2018_09_30 of compute (#4185)
iscai-msft Jun 28, 2019
d32e978
Network with api version 2019_02_01 (#3463)
iscai-msft Jun 28, 2019
b99c3ef
Add Azure identity sample for Event Hubs README (#4188)
conniey Jun 28, 2019
7e328f1
Issue #3937: Paged flux draft PR (#4045)
srnagar Jun 28, 2019
6c2fc73
Added code snippet path in pom
sima-zhu Jun 29, 2019
73e8ed3
Merge branch 'storage-proto' of https://github.com/Azure/azure-sdk-fo…
sima-zhu Jun 29, 2019
124173f
make change to pom.client.xml
sima-zhu Jun 29, 2019
d4cb144
revert blob changes
sima-zhu Jun 29, 2019
674e041
revert blob changes 2
sima-zhu Jun 29, 2019
2935bd3
Fixed extra changes
sima-zhu Jun 29, 2019
a235a9b
More reverts
sima-zhu Jun 29, 2019
dd7e986
more reverts
sima-zhu Jun 29, 2019
e6342aa
reverts
sima-zhu Jun 29, 2019
a48efde
fix shared key
sima-zhu Jun 29, 2019
9f1b5b0
Remove unnecessary pom setting
sima-zhu Jun 29, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.client.xml
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@
-snippetpath ${project.basedir}/eventhubs/client/azure-eventhubs/src/samples/java
-snippetpath ${project.basedir}/keyvault/client/keys/src/samples/java
-snippetpath ${project.basedir}/keyvault/client/secrets/src/samples/java
-snippetpath ${project.basedir}/storage/client/queue/src/samples/java/javadoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be javadoc at the end of this line

</additionalOptions>
</configuration>
</reportSet>
Expand Down
20 changes: 18 additions & 2 deletions storage/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@

<build>
<plugins>
<!-- Now that all checkstyle issues have been resolved, override the
default behavior to make checkstyle fail on error and violation. -->
<!-- For initial implementation all Checkstyle, SpotBugs, and JavaDocs errors will be ignored -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
Expand All @@ -115,6 +114,23 @@
<failOnError>false</failOnError>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<failOnError>true</failOnError>
<failOnWarnings>true</failOnWarnings>
</configuration>
</plugin>

<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<failOnError>false</failOnError>
</configuration>
</plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes can all be removed - it is centrally managed now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkstyle should be removed too, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all configuration of these features is centralised

</plugins>
</build>
</project>
Loading