Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addServicePrincipalSupportInKafkaConnector #39490

Merged
merged 6 commits into from
Apr 2, 2024
Merged

addServicePrincipalSupportInKafkaConnector #39490

merged 6 commits into from
Apr 2, 2024

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Apr 1, 2024 •
edited by kushagraThapar
Loading

Add service principal support in kafka connector
Fixes: #38767

Example to use service principal auth:

config.put("kafka.connect.cosmos.auth.type", "ServicePrincipal");
config.put("kafka.connect.cosmos.account.tenantId", $"{ACCOUNT_TENANT_ID}");
config.put("kafka.connect.cosmos.auth.aad.clientId", $"{ACCOUNT_AAD_CLIENT_ID}");
config.put("kafka.connect.cosmos.auth.aad.clientSecret", $"{ACCOUNT_AAD_CLIENT_SECRET}");

@github-actions github-actions bot added the Cosmos label Apr 1, 2024
kushagraThapar
kushagraThapar approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good @xinlian12 - with some minor comments on re-naming to kafka prefix classes.

sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md Outdated Show resolved Hide resolved
...fka-connect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosAuthTypes.java Show resolved Hide resolved
...ect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosAzureEnvironments.java Show resolved Hide resolved
...ect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosAzureEnvironments.java Show resolved Hide resolved
...fka-connect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosConstants.java Outdated Show resolved Hide resolved
...nect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosExceptionsHelper.java Outdated Show resolved Hide resolved
...ka-connect/src/main/java/com/azure/cosmos/kafka/connect/implementation/CosmosSchedulers.java Outdated Show resolved Hide resolved
@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

Flaky local tests: batchItemETagTest

@xinlian12
Copy link
Member Author

/check-enforcer override

@xinlian12 xinlian12 merged commit 997c1e0 into Azure:main Apr 2, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@milismsft milismsft Awaiting requested review from milismsft

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@simorenoh simorenoh Awaiting requested review from simorenoh

@jeet1995 jeet1995 Awaiting requested review from jeet1995

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Kafka V2]Add AAD support
2 participants
@xinlian12 @kushagraThapar